Repository navigation
RDC compression for sas7bdat writes - #433
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up on #432. It adds RDC compression to the sas7bdat writer, and also addresses some corner cases in the COMP page.
The RDC compression has been implemented to closely match the RLE compression. In particular, the RDC code now lives in a new file,
src/sas/readstat_sas_rdc.{c,h}, which both the reader and the writer use.Testing
The validation has been mainly manual on a similar test corpus as #432.
The test coverage of the RDC compression corresponds to the coverage of the RLE compression: It's implicitly tested in the round-trip tests.
Fuzzing
There is a fuzzing target for RLE (
fuzz_compression_sas_rle.c) in the repo but I don't see it being invoked by this build or the OSS-Fuzz build. I haven't added a corresponding target for RDC. If something should be done in this regard, please let me know.