Repository navigation
Add support for invokedynamic string concatenation. - #95
Closed
RobertWesner wants to merge 1 commit into
Closed
RobertWesner wants to merge 1 commit into
RobertWesner wants to merge 1 commit into
Conversation
Collaborator
|
Thank you for contribution. I merged your changes with some modifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heyo! We had issues over at https://github.com/legacyminecraft/BungeePoseidon after refactoring from StringBuilder to string literal concatination. We had to drop the
&ip=param to be compatible with the Betacraft proxy, which removed the need for the builder.The AuthHook agent only checked for LDC string constants. Worked from my testing on my Java 17+ ViaProxy instance, feel free to test more if necessary.