Repository navigation
fix: legacy chest dialog labels and right-click option cycling - #1384
Open
MachoPiggies wants to merge 2 commits into
Open
MachoPiggies wants to merge 2 commits into
MachoPiggies wants to merge 2 commits into
Conversation
…ess of click type
…appings, causing single option and slider buttons to hold invalid names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on a 1.14.1 client connected to Paper 26.3 that the option selector and slider in chest dialogs looked like they weren’t responding to clicks. Submitting the dialog returned the correct updated values, but the item names never showed them. Adding options.generic_value to the 1.16.2 translation mappings fixed both labels.
I also fixed the option selector’s right-click behaviour. The tooltip says right-click goes back, but both mouse buttons progressed the selection forwards. Right-click now goes to the previous option and wraps from the first option to the last.