Repository navigation
fix(linux): match the dialog tests to the TLS default and keep cloud stack tests out of CI - #4067
Merged
Merged
Conversation
…stack tests out of CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VerifyFullas the network TLS for MySQL and PostgreSQL, the default before fix(core): start a new connection on the TLS mode the engine's own client uses #4051 made itPrefer(core ADR 0014). The socket switch test now picks Require before the socket and checks it comes back; the socket folder test expects PostgreSQL'sPreferafter a host is typed, then picks VerifyFull so the MongoDB step still checks the network's TLS comes back.cloud_stackmodule. nextest's default filter leaves out::cloud_stack::and the account crate'scloud_stackbinary, so the Docker job's--run-ignored onlyno longer runs a test CI cannot reach the backend for.Test plan
linux / Fast checksandlinux / Flatpak Devel (aarch64)onconnect_dialog::testslines 1594 and 1615, andlinux / Docker tests (tablepro)onthe_page_signs_in_through_the_browser_shows_the_account_and_signs_out(TABLEPRO_CLOUD_EMAIL_DOMAIN is not set).cargo test -p tablepro --lib connect_dialog::passes 106 tests;cargo clippy -p tablepro --all-targets -- -D warningspasses.cargo nextest list -p tablepro-account --run-ignored onlylists 0 cloud stack tests, 7 with--ignore-default-filter.