Skip to content

fix(linux): match the dialog tests to the TLS default and keep cloud stack tests out of CI - #4067

Merged
datlechin merged 1 commit into
mainfrom
fix/linux-dialog-tls-default-tests
Nov 6, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/linux-dialog-tls-default-tests

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

  • Connection dialog tests from feat(linux): connection URLs and Unix sockets for PostgreSQL and MySQL #4048 expected VerifyFull as the network TLS for MySQL and PostgreSQL, the default before fix(core): start a new connection on the TLS mode the engine's own client uses #4051 made it Prefer (core ADR 0014). The socket switch test now picks Require before the socket and checks it comes back; the socket folder test expects PostgreSQL's Prefer after a host is typed, then picks VerifyFull so the MongoDB step still checks the network's TLS comes back.
  • The account page's tablepro-cloud test moves into a cloud_stack module. nextest's default filter leaves out ::cloud_stack:: and the account crate's cloud_stack binary, so the Docker job's --run-ignored only no longer runs a test CI cannot reach the backend for.

Test plan

  • Main run 42153730119 failed linux / Fast checks and linux / Flatpak Devel (aarch64) on connect_dialog::tests lines 1594 and 1615, and linux / Docker tests (tablepro) on the_page_signs_in_through_the_browser_shows_the_account_and_signs_out (TABLEPRO_CLOUD_EMAIL_DOMAIN is not set).
  • In the Linux dev container: cargo test -p tablepro --lib connect_dialog:: passes 106 tests; cargo clippy -p tablepro --all-targets -- -D warnings passes.
  • cargo nextest list -p tablepro-account --run-ignored only lists 0 cloud stack tests, 7 with --ignore-default-filter.

@datlechin
datlechin merged commit 6f580fb into main Nov 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant