Skip to content

Introduce fs_warning_level & filesystem access log - #289

Merged
marchc1 merged 7 commits into
SourceDotNET:mainfrom
spacevx:feat/filesystem-logging
Nov 20, 2026
Merged

marchc1 merged 7 commits into
SourceDotNET:mainfrom
spacevx:feat/filesystem-logging

Conversation

@spacevx

@spacevx spacevx commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Source.Filesystem/DiskSearchPath.cs Outdated
if (!info.Exists)
return BaseFileSystem.g_AddonFileSystem.GetFileSize(absPath) >= 0 ? DateTime.UnixEpoch.AddSeconds(1) : DateTime.UnixEpoch;

(parent as BaseFileSystem)?.LogAccessToFile("filetime", absPath, "");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this cause a lock on every Time access though. even if there was no log callback

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably, good catch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, check my last commit

@marchc1
marchc1 merged commit 23b6668 into SourceDotNET:main Nov 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants