Repository navigation
Port env_fog_controller - #287
Merged
Merged
Conversation
marchc1
approved these changes
Nov 20, 2026
marchc1
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map fog never showed up:
env_fog_controllerwas only a network table on the server, its keyvalues were never read andInitFogControllerwas commented out, so the player never got a fog controller. The client and shader side were already there. This ports the rest from the 2013 SDK:FogController: keyfields (fogcolor,fogcolor2,fogdir,fogenable,fogblend,fogstart,fogend,fogmaxdensity,farz,foglerptime,fogradial,use_angles), all the inputs (TurnOn,TurnOff,SetColor,SetStartDist,SetRadial,SetColorLerpTo,StartFogTransition...),Spawn,Activate,UpdateTransmitStateandDrawDebugTextOverlaysFogSystem: picks the master fog controller on level load, and forces radial fog on official maps like the SDKSkyCamera: thefogradialkeyvalue, and radial skybox fog forced on official maps like the SDKGameRules.IsOfficialMap, false by default as in the SDKBasePlayer.InitFogControlleron spawn and theSetFogControllerinputGMod also has
fogcolor_hdr,fogcolor2_hdr,HDRColorScale,SetColorHDR,SetColorSecondaryHDRandSetMaxDensityLerpTo, which aren't in the 2013 SDK or Obsoletium, so they're left out of this PR.Inputs changing the fog after the map has loaded need #286 to reach the client.
Tested: all four configurations build,
Source.Common.TestsandGame.Server.Testspass. With #286,SetRadial 1/0on the map's controller switches between radial and planar fog, matchingfog_radial 1/0pixel for pixel.