Repository navigation
Add missing Player/Entity Lua methods and fix Entity:IsNPC - #285
Merged
Merged
Conversation
Used by weapon_base, weapon_medkit and the sandbox weapons, which errored with 'attempt to call method ... (a nil value)'.
It always returned false, breaking addons and gamemodes that filter NPCs.
ZehMatt
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player:StripWeapons()(server): removes every weapon withRemoveAllWeapons. Used by the base gamemode (PlayerSpawnAsSpectator) and TTT.Player:LagCompensation(bool): starts or finishes lag compensation on the server. It does nothing on the client, and also when there is no current user command (for example when called from a timer), instead of reaching the NULLCUserCmderror. Used byweapon_fists,weapon_medkitand TTT weapons.Entity:MuzzleFlash(): callsDoMuzzleFlashon animating entities. Used byweapon_base.Entity:IsNPC()always returned false, it now returns the entity'sIsNPC()on both realms.Tested: all four configurations build and
Source.Common.Testspass. On gm_construct, before:attempt to call method 'StripWeapons'/'LagCompensation'/'MuzzleFlash' (a nil value)andIsNPC()false for anpc_citizenon server and client. After: all four behave as expected on both realms.