Skip to content

Fix/filesystem search paths - #270

Merged
marchc1 merged 8 commits into
SourceDotNET:mainfrom
spacevx:fix/filesystem-search-paths
Nov 17, 2026
Merged

marchc1 merged 8 commits into
SourceDotNET:mainfrom
spacevx:fix/filesystem-search-paths

Conversation

@spacevx

@spacevx spacevx commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Source.Filesystem/BaseFileSystem.cs Outdated
newPath = new(RelativePathToFullPath(path, "GAME", fullPath));
}
else {
newPath = Path.IsPathFullyQualified(path) ? new(path) : Path.GetFullPath(new(path));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should pass AppContext.BaseDirectory to GetFullPath (see: the new changes from #267)

@spacevx spacevx Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally i dropped GetFullPath. Gmod RemoveSearchPath never makes the path absolute (win/linux/macos)
(See my last commit)

matchAll = true;
#endif
}
else if (path.Contains(".bsp", StringComparison.OrdinalIgnoreCase)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a RemoveVPKFile branch I believe

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(may need a double check)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked in the gmod binaries there's no RemoveVPKFile branch in RemoveSearchPath (checked on windows/linux/macos)
See CBaseFileSystem::RemoveSearchPath in IDA

@marchc1
marchc1 merged commit 7829306 into SourceDotNET:main Nov 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants