Repository navigation
Conversation
Member
|
While I want to do this, we probably should hold off on deviations until we have the API solid. I will absolutely accept and review this though in the future |
Contributor
Author
No problem i think we can just let it open, unless you want me to do another one for the fixes |
spacevx
marked this pull request as draft
November 16, 2026 22:28
Member
|
I would say probably should close it but save the branch for later (don't want these piling up too much, and it will probably be a while) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
util.TableToJSONto match Garry's Mod one, but writes JSON directly instead of building aBootil::Data::Treefirst like GMod does, as suggested in Facepunch/garrysmod-requests#2822Fixes
5.0instead of5tostring, bool keys were dropped, andinf/ NaN were written as0instead ofnull{[""] = x}gave{"": x}instead of[x]Benchmarks
(Benchmark was done on a Ryzen 9 9950x on W11, if you want me to give the code used for the benchmark don't hesitate)