Skip to content

Lua (& more) - #264

Merged
marchc1 merged 23 commits into
mainfrom
lua
Nov 16, 2026
Merged

marchc1 merged 23 commits into
mainfrom
lua

Conversation

@callumok2004

Copy link
Copy Markdown
Member

No description provided.

@marchc1

marchc1 commented Nov 16, 2026

Copy link
Copy Markdown
Member

This has merge conflicts now, still reviewing it while I wait but just letting you know.
Also #266 adds Float16 as well; cc. @spacevx
Either one of you could remove it, just coordinate

@spacevx

spacevx commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Will remove it

@spacevx

spacevx commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Merge this PR before mine, so i can use his Float16

@marchc1

marchc1 commented Nov 16, 2026

Copy link
Copy Markdown
Member

I will yeah, almost done reviewing it

@marchc1 marchc1 mentioned this pull request Nov 16, 2026
readonly int Type = type;
readonly string? FileName = fileName;

public void Destroy() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get called through a garbage collector method in glua? Haven't checked but I want to make sure just in case

Comment thread Game.Client/GarrysMod/C_GMOD_Player.cs Outdated
bool ret = base.CreateMove(inputSampleTime, ref cmd);

if (gpGlobals.MaxClients == 1 && IsLocalPlayer())
UpdateButtonState(cmd.Buttons);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Singleplayer's case should be called in C_GMOD_Player::Simulate I believe, not here

@marchc1
marchc1 merged commit eafa846 into main Nov 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants