Repository navigation
Implement engine client lighting queries - #258
Merged
Merged
Conversation
Implement ComputeLighting, ComputeDynamicLighting, GetLightForPoint and GetLightForPointFast on the engine client, and add IModelRender.SetupLighting, all matching GMod's engine.dll.
marchc1
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second split from #256.
IEngineClient.ComputeLighting,ComputeDynamicLighting,GetLightForPoint,GetLightForPointFastnow go through the lightcache instead of throwing or returning zero.ComputeLightingtakes a nullable normal (null returns the averaged ambient cube, like the SDK'spNormal == NULL).IModelRender.SetupLighting: sets the ambient cube, local cubemap and up to two local lights on the render context, same as SDK 2013CModelRender::SetupLighting.ModelRender.WorldLightToMaterialLightis now internal for reuse by the lightcache.Studiorender calls are guarded for dedicated builds. Behaviour was checked against GMod's engine.dll.