Repository navigation
Input improvements - #250
Merged
Merged
Conversation
spacevx
marked this pull request as draft
November 12, 2026 16:01
Contributor
Author
|
I also fixed the Keyboard tab in the options The Keyboard tab was empty in game, the map pakfile was returning a size of 0 for files it doesn't have, so kb_act.lst was never read Changing a key now actually binds it and saves it (apply/unbind/defaults were never ported) config.cfg is now written like gmod (on startup, on quit and with host_writeconfig), also added unbind, bind_mac, unbind_mac and host_writeconfig_lua Lua archived convars (client.vdf / server.vdf) were never saved because of a KeyValues bug, and the KeyValues text writer was writing broken files Didn't do the steam cloud logic as i don't know if it's really useful and something you want/can implement? |
spacevx
marked this pull request as ready for review
November 12, 2026 16:59
marchc1
previously approved these changes
Nov 12, 2026
marchc1
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using Source.NET on an AZERTY keyboard I noticed the default key to run/move was Z instead of W like in gmod
While fixing that I ended up fixing a few other input things
Windows keys now follow the keyboard layout like gmod, and menus use the Windows virtual key
Linux has nothing to change normally
macOS now uses the same key mapping as gmod. (NOT TESTED!!), only checked against
inputsystem.dylibandlauncher.dylibin IDA (I can remove it if no one can test it)Input state is only reset when the window loses focus. Which is how it's working in gmod and also checked in obsolete-source-engine
F1-F12 now run their binds in the main menu, so F10 (by default on azerty it's ` and not F10) opens the console like in gmod
Note: in some places obsolete-source-engine doesn't match what gmod actually does (it has
-nonqwertyon Linux and goes through SDL on macOS, gmod has neither), so I prioritized gmod implementation/logic