Skip to content

Various fixes - #244

Merged
marchc1 merged 7 commits into
SourceDotNET:mainfrom
spacevx:various-fixes
Nov 12, 2026
Merged

marchc1 merged 7 commits into
SourceDotNET:mainfrom
spacevx:various-fixes

Conversation

@spacevx

@spacevx spacevx commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Missing methods (& behaviour), ported from Obsoletium

Weapon sounds wasn't working on french language (same for other no english): Interval.Read was culture-dependent ("1.0" → 0), now uses atof just like ReadInterval

Sound effect volume slider stuck at 0 even after editing it/saving it GModSFXSlider wasn't bound to volume_sfx

volume_sfx now scales game sounds like GMOD in MIX_ScaleChannelVolume and DSP presets 35-38 in DSP_Process

AR2 couldn't reload because ammo indices started at 0 instead of 1 (CAmmoDef)

Missing reload sounds: pistol, RPG, shotgun (now one shell at a time)

LocalPlayerFilter had no recipients, so its sounds were dropped (for example)

Client animation sound events, for the 357/AR2 reload sounds (DoAnimationEvents,FireEvent, C_BaseViewModel::FireEvent)

{
public LocalPlayerFilter() : base() {

if (C_BasePlayer.GetLocalPlayer() != null)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little surprised this didnt exist already

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah same lol that's why weapon reload sounds didn't worked in some case

@marchc1
marchc1 merged commit 7995356 into SourceDotNET:main Nov 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants