Repository navigation
Various fixes - #244
Merged
Merged
Various fixes#244
Conversation
marchc1
approved these changes
Nov 12, 2026
| { | ||
| public LocalPlayerFilter() : base() { | ||
|
|
||
| if (C_BasePlayer.GetLocalPlayer() != null) |
Member
There was a problem hiding this comment.
A little surprised this didnt exist already
Contributor
Author
There was a problem hiding this comment.
Yeah same lol that's why weapon reload sounds didn't worked in some case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing methods (& behaviour), ported from Obsoletium
Weapon sounds wasn't working on french language (same for other no english):
Interval.Readwas culture-dependent ("1.0" → 0), now usesatofjust likeReadIntervalSound effect volume slider stuck at 0 even after editing it/saving it
GModSFXSliderwasn't bound tovolume_sfxvolume_sfxnow scales game sounds like GMOD inMIX_ScaleChannelVolumeand DSP presets 35-38 inDSP_ProcessAR2 couldn't reload because ammo indices started at 0 instead of 1 (
CAmmoDef)Missing reload sounds: pistol, RPG, shotgun (now one shell at a time)
LocalPlayerFilterhad no recipients, so its sounds were dropped (for example)Client animation sound events, for the 357/AR2 reload sounds (
DoAnimationEvents,FireEvent,C_BaseViewModel::FireEvent)