Repository navigation
Fix V8 issue with CET - #242
Merged
Merged
Conversation
Member
|
Want @ZehMatt's opinion before merging, but to @HappyDOGE and I this looks fine |
ZehMatt
approved these changes
Nov 12, 2026
ZehMatt
left a comment
Contributor
There was a problem hiding this comment.
Looks like its returning to stack space, as to why I don't know but it seems to solve this issue so I think we can go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CET is a CPU security feature (Intel 11th gen+, AMD Zen 3+) that keeps a hidden copy of return addresses to block exploits. Since .NET 9, Windows turns it on for our CEF process, and V8 crashes under it. That breaks the menu as soon as you click New Game or Find Multiplayer.
Like this:

(It's disabled only for the CEF Process and not Source process)
To check if you have it on, with the game running:
ON = you get the crash
I have a Ryzen 9 9950X with W11