Repository navigation
Store VPK entries as structs indexing the tree buffer - #198
Merged
Merged
Conversation
marchc1
approved these changes
Oct 16, 2026
marchc1
left a comment
Member
There was a problem hiding this comment.
A lot of this is old stuff from https://github.com/antim0118/SharpVPK (specifically this fork since it had V1 and V2 support) and then my attempts to improve it, so not surprising this was still kinda awful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into whats using up quite a bit of memory I noticed that each VpkEntry held a couple strings while also keeping all the bytes of the tree so I refactored it to index into the byte array and turning VpkgEntry into a plain struct which improves the overhead quite a bit.
Before:

After:
