Repository navigation
Gmod HTML + menusystem - #184
Conversation
Assembly.LoadFrom is a bad way of doing this imo
…pying This resulted in copying being AWFUL on performance this also fixes @callumok2004's previous Steam HTML issues
Keeping it like this in case there are actually convars menusystem blocks, need to double check
HTTP, material fixes, motionsensor, permissions, steamworks, IVideoWriter NOTE: The clientside implementations of menu functions are guesses! They may differ! NEED TO CHECK!!! NOTE: The clientside (not menu) were NOT decompiled and need to be decompiled later.
This was affecting the console and html panels not playing nice
This fixes the tsunami of mips failing on some vtf textures
This is a basic version; it apparently only would work on Windows (didn't realize this API uses C++/CLI... should've realized sooner). I am evaluating a better approach. This likely will end up meaning a CEF version bump, but not like I'm complaining as long as it works
|
I'm going to test Linux briefly, but this is working on my Windows install. (I can see that it's already causing CI failures on Linux so that's not really reassuring 💔) Unfortunately, for sandboxed CEF, a process that is shared between the game and the CEF renderer is required, which is what gmod-html does as well. There's not a way around that unless we wanted to not run it sandboxed (which I think would be unacceptable from a user-security standpoint). This puts us at CEF 154, which is a significant upgrade from Garry's Mod's 86, and also beyond GModPatchTool's CEF 137. I think this is fine? The menu doesn't break, which is a good sign. I am a bit less worried about addon compatibility here. You could argue in general that addons shouldn't even be using CEF heavily, but that's Facepunch dropping the ball in my opinion when it comes to expanding the API's capabilities (and something we could fix if we ever decided to split off API wise, but that's a decision for way, way later, and one that comes with its own problems). Something @callumok2004 did which I am interested in is an experimental VGUI replacement for the main menu, that functions almost identically (which would be good for running with -nochromium, the game should not rely on it imo as much as it does, that has set a horrible precedent) I do think however that addons should not rely on a specific version of CEF to function. If an addon is relying specifically on a framework that is known to be highly vulnerable to exploits to not change its version, we should not accommodate. Bit of a rant but this is just a combination of my thoughts at the moment and some reasonings |
|
CEF 154 in Source.net before GMod even has CEF 86 for all platform is crazy. |
This is nowhere near done, just setting up the PR now
I need to rethink the Chromium approach itself because CefSharp is not a good option here; it's C++/CLI, so it's only for Windows. This also needs the menusystem; which is coming in the commits later today, and then tomorrow I'll redo the Chromium side (likely going to have to use a C++ native process here... it is what it is)