Repository navigation
Conversation
| base.Spawn(); | ||
| bool allowPrecache = IsPrecacheAllowed(); | ||
| SetAllowPrecache(true); | ||
| ScriptedEntity.CallFunction("Initialize", false); |
There was a problem hiding this comment.
It doesnt look like Initialize gets called in here, or SENT_Point, AI, LuaNextBot; only happens here
You should implement it in the other scripted entities, accurately to gmods binary obv, not sure where it is in other parts
| #if CLIENT_DLL | ||
| if (ParentEntity.EntIndex() != -1) { | ||
| C_BaseEntity.SetAllowPrecache(true); | ||
| CallFunction("Initialize", true); |
There was a problem hiding this comment.
Actually now I see this Initialize, but its only being called clientside, not serverside?
|
|
||
| StudioFlags drawnFlags = flags; | ||
| if ((flags & StudioFlags.Render) != 0 && weapon != null) { | ||
| drawnFlags = flags | StudioFlags.Transparency; |
There was a problem hiding this comment.
OldAnimationParity isnt used in gmod?
| [LuaMethod] | ||
| static int Weapon__SetClip1(ILuaInterface lua) { | ||
| BaseCombatWeapon weapon = LuaEntity.Get_Weapon(1, false)!; | ||
| weapon.SetDropped(); |
There was a problem hiding this comment.
Why is the weapon dropped when setting clips?
| public int EntityType; | ||
| public BaseEntity? ParentEntity; | ||
| [NetworkName("m_strScriptName")] | ||
| public InlineArray64<char> ScriptName; |
There was a problem hiding this comment.
Are you sure this is 64? Have you made sure this wont affect the network CRC? Double check
|
|
||
| [NetworkName("m_strHoldType")] | ||
| public InlineArray64<char> HoldType; | ||
| public InlineArray80<char> HoldType; |
There was a problem hiding this comment.
Are you sure this is 80? Have you made sure this wont affect the network CRC? Double check
|
|
||
| public static void QuaternionMult(in Quaternion p, in Quaternion q, out Quaternion qt) { | ||
| qt = Quaternion.Multiply(p, q); | ||
| QuaternionAlign(p, q, out Quaternion q2); |
There was a problem hiding this comment.
You should probably add the original guard against &p == &qt (there's an Unsafe.Function for this that I can't remember right now)
|
The other issues I raised seem to be correct after double checking |
No description provided.