Repository navigation
Conversation
Member
|
This returns here in gmod too, without it, it "finishes" before it has actually finished |
Author
I don't think this is the case. The return existing causes the whole thing to exit early, by not allowing it to properly continue to its next 'page' and gets the job stuck in a permanent loop because it isn't allowed to cleanly finish. (800 being the page size.) |
|
I'm surprised I never caught this lol Def merge pls |
Member
|
Fixed in 26314f5 |
Member
|
The problem is a lack of IAddonDownloadNotification then? |
Member
|
yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot see a genuine reason for a 'return' existing here.