Skip to content

Get addons mounting. - #148

Closed
ErisCodes wants to merge 1 commit into
SourceDotNET:mainfrom
ErisCodes:main
Closed

ErisCodes wants to merge 1 commit into
SourceDotNET:mainfrom
ErisCodes:main

Conversation

@ErisCodes

Copy link
Copy Markdown

I cannot see a genuine reason for a 'return' existing here.

@callumok2004

Copy link
Copy Markdown
Member

This returns here in gmod too, without it, it "finishes" before it has actually finished

@ErisCodes

ErisCodes commented Oct 9, 2026 •

Copy link
Copy Markdown
Author

This returns here in gmod too, without it, it "finishes" before it has actually finished

I don't think this is the case. The return existing causes the whole thing to exit early, by not allowing it to properly continue to its next 'page' and gets the job stuck in a permanent loop because it isn't allowed to cleanly finish. (800 being the page size.)

@VeXan39231

Copy link
Copy Markdown

I'm surprised I never caught this lol

Def merge pls

@callumok2004

Copy link
Copy Markdown
Member

Fixed in 26314f5

@marchc1

marchc1 commented Oct 9, 2026

Copy link
Copy Markdown
Member

The problem is a lack of IAddonDownloadNotification then?

@callumok2004

Copy link
Copy Markdown
Member

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants