Repository navigation
Reduce boiler plate code for bit sets, optimize it a bit as well - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed them from BitVec to BitSet, I know one can debate its essentially the same and it actually is but I prefer "set" when its just used to mark slots where a bit vector is typically referred to a value representation of N bits. Also I had to setup another source generator to get rid of that boiler plate code, really frustrating that in C# one can't just have
using PlayerBitSet = BitSet<uint, 128>.Also for the first time we finally have now some tests, so there will be now a test project in where we can expand everything we want tested.