Repository navigation
Conversation
Currently, we use the struct visibility for projection methods. This means that if a public struct uses `#[pin_data]`, the projection methods will be defined on them with public visibility despite the projection struct having no publicly accessible field. This both exposes the implementation detail of such structs, and add noise to the generated documentation. Use the combined field visibility for this instead, where that of the most visible field is used instead. Signed-off-by: Gary Guo <gary@garyguo.net>
`HasPinData` is an implementation detail of pin-init to communicate from `#[pin_data]` macro to `pin_init!()` macro on how to initialize the struct. Thus, `HasPinData` is marked as `#[doc(hidden)]`; however, Rustdoc still renders the impl. Thus, also mark impl as `#[doc(hidden)]` Signed-off-by: Gary Guo <gary@garyguo.net>
nbdd0121
force-pushed
the
dev/project-vis
branch
from
November 18, 2026 13:14
e811fdf to
c03348c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we use the struct visibility for projection methods. This means
that if a public struct uses
#[pin_data], the projection methods will bedefined on them with public visibility despite the projection struct having
no publicly accessible field. This both exposes the implementation detail
of such structs, and add noise to the generated documentation.
Use the combined field visibility for this instead, where that of the most
visible field is used instead.