Skip to content

f-1281 removed legacy Redux store - #1654

Open
morozov-av wants to merge 3 commits into
RunestoneInteractive:mainfrom
morozov-av:f-1281
Open

morozov-av wants to merge 3 commits into
RunestoneInteractive:mainfrom
morozov-av:f-1281

Conversation

@morozov-av

Copy link
Copy Markdown
Contributor
  1. Removed legacy Redux store, old slices
  2. Now app uses unified store implementation, with related selectors, state references

@morozov-av
morozov-av requested a review from bnmnetp as a code owner November 5, 2026 19:56
@morozov-av

Copy link
Copy Markdown
Contributor Author

Accessibility failed due to tiptap-extension-code-block-prism and @playwright/test version
Fix: #1648

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the except route leaves both accommodations links pointing to a page with no matching React route, causing a 404 instead of opening the scheduler.

1 open issue
What changed in this PR

This PR moves the assignment builder to its unified Redux store, removing legacy state management and updating selectors and tests.

Changes:

  • Switches the app entry point and state types to the unified store.
  • Replaces assignmentTemp references with assignment, including test fixtures.
  • Deletes legacy slices, store tests, and the accommodation scheduler and route.

Paths below are relative to bases/rsptx/assignment_server_api/assignment_builder/src/.

File Description
store/​searchExercises/​searchExercises.logic.ts Uses the unified root-state type.
store/​readings/​readings.logic.ts Uses the unified root-state type.
store/​exercises/​exercises.logic.ts Uses the unified root-state type.
store/​chooseExercises/​chooseExercises.logic.ts Uses the unified root-state type.
store/​assignmentExercise/​assignmentExercise.logic.ts Uses the unified root-state type.
store/​assignmentExercise/​assignmentExercise.logic.api.ts Reads selected assignment IDs from unified state.
store/​assignment/​assignment.logic.ts Updates the assignment selector and state type.
store/​assignment/​assignment.logic.spec.ts Tests the renamed assignment state key.
state/​student/​studentSlice.js Removes legacy student and accommodation state.
state/​store.ts Removes the legacy store configuration.
state/​store.spec.ts Removes legacy store tests.
state/​epicker/​ePickerSlice.js Removes the legacy exercise-picker slice.
state/​assignment/​assignSlice.js Removes legacy assignment state and thunks.
renderers/​exceptionScheduler.jsx Removes the accommodation scheduler screen.
index.tsx Connects the Redux provider to the unified store.
hooks/​useSelectedAssignment.spec.ts Updates assignment state fixtures.
hooks/​useReadingsSelector.spec.ts Updates assignment state fixtures.
hooks/​useExercisesSelector.spec.ts Updates assignment state fixtures throughout.
components/​routes/​AssignmentBuilder/​components/​exercises/​components/​SearchExercises/​SmartSearchExercises.tsx Adds whitespace only.
App.tsx Uses the user authorization selector and removes the scheduler route.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants