Repository navigation
f-1281 removed legacy Redux store - #1654
Open
morozov-av wants to merge 3 commits into
Open
morozov-av wants to merge 3 commits into
morozov-av wants to merge 3 commits into
Conversation
morozov-av
commented
Nov 5, 2026
Contributor
- Removed legacy Redux store, old slices
- Now app uses unified store implementation, with related selectors, state references
Contributor
Author
|
Accessibility failed due to tiptap-extension-code-block-prism and @playwright/test version |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the except route leaves both accommodations links pointing to a page with no matching React route, causing a 404 instead of opening the scheduler.
1 open issue
What changed in this PR
This PR moves the assignment builder to its unified Redux store, removing legacy state management and updating selectors and tests.
Changes:
- Switches the app entry point and state types to the unified store.
- Replaces
assignmentTempreferences withassignment, including test fixtures. - Deletes legacy slices, store tests, and the accommodation scheduler and route.
Paths below are relative to bases/rsptx/assignment_server_api/assignment_builder/src/.
| File | Description |
|---|---|
store/searchExercises/searchExercises.logic.ts |
Uses the unified root-state type. |
store/readings/readings.logic.ts |
Uses the unified root-state type. |
store/exercises/exercises.logic.ts |
Uses the unified root-state type. |
store/chooseExercises/chooseExercises.logic.ts |
Uses the unified root-state type. |
store/assignmentExercise/assignmentExercise.logic.ts |
Uses the unified root-state type. |
store/assignmentExercise/assignmentExercise.logic.api.ts |
Reads selected assignment IDs from unified state. |
store/assignment/assignment.logic.ts |
Updates the assignment selector and state type. |
store/assignment/assignment.logic.spec.ts |
Tests the renamed assignment state key. |
state/student/studentSlice.js |
Removes legacy student and accommodation state. |
state/store.ts |
Removes the legacy store configuration. |
state/store.spec.ts |
Removes legacy store tests. |
state/epicker/ePickerSlice.js |
Removes the legacy exercise-picker slice. |
state/assignment/assignSlice.js |
Removes legacy assignment state and thunks. |
renderers/exceptionScheduler.jsx |
Removes the accommodation scheduler screen. |
index.tsx |
Connects the Redux provider to the unified store. |
hooks/useSelectedAssignment.spec.ts |
Updates assignment state fixtures. |
hooks/useReadingsSelector.spec.ts |
Updates assignment state fixtures. |
hooks/useExercisesSelector.spec.ts |
Updates assignment state fixtures throughout. |
components/routes/AssignmentBuilder/components/exercises/components/SearchExercises/SmartSearchExercises.tsx |
Adds whitespace only. |
App.tsx |
Uses the user authorization selector and removes the scheduler route. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
