Repository navigation
Drop the missing source/_static from tojupyter_static_file_path - #659
Conversation
lectures/source/_static does not exist, so every notebook build logged "tojupyter_static_path entry .../lectures/source/_static does not exist". sphinx-tojupyter copies only the entries that exist, so dropping it changes nothing but the warning. See QuantEcon/actions#300. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMYFuqCc4A8Y1tGJoXT
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a straightforward configuration cleanup (removing a non-existent static-path entry) with no review evidence of remaining problems or unresolved concerns.
No open issues 🎉
What changed in this PR
Removes a non-existent static-path entry from the sphinx-tojupyter configuration so notebook builds no longer emit a warning about lectures/source/_static.
Changes:
- Drop
source/_staticfromtojupyter_static_file_path, leaving only the existing_staticentry.
| File | Description |
|---|---|
| lectures/_config.yml | Removes the missing source/_static entry from tojupyter_static_file_path to prevent sphinx-tojupyter warnings during notebook builds. |
Review effort: Balanced
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a narrow configuration cleanup that removes only an invalid static-path entry to eliminate recurring build warnings while keeping the existing static asset path unchanged, and no active issues were identified in the review evidence.
No open issues 🎉
Review effort: Balanced
lectures/source/_staticdoes not exist, so every notebook build logsWARNING: tojupyter_static_path entry …/lectures/source/_static does not exist. This drops it fromtojupyter_static_file_pathinlectures/_config.yml, leaving_static, which does exist. sphinx-tojupyter copies only the entries that exist, so nothing changes but the warning.The warning has gone unnoticed because sphinx-tojupyter ends a notebook build with status 0 before
-W --keep-goingcan fail it. See QuantEcon/actions#300:build-lectureswill fail a jupyter build on a warning like this one, and QuantEcon/actions' lecture matrix builds this repository withbuild-lectures.Claude Code (on behalf of mmcky)
🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMYFuqCc4A8Y1tGJoXT