Repository navigation
fix: conversation context is not a spectra bridge signal (#525) - #536
Open
kiki830621 wants to merge 4 commits into
Open
kiki830621 wants to merge 4 commits into
kiki830621 wants to merge 4 commits into
Conversation
The detection table of rules/spectra-bridge.md listed "Conversation context" as a fourth signal, but idd-comment Step 0.7 reads three and the skill does not ask the model to judge. The row is removed and the rule says that a call made in the middle of a spectra-discuss session passes --resume-spectra; the maintainer chose not to add an automatic path. The line count of the rule is unchanged, so Hard rule 6 stays on line 116. The spectra-bridge-detect suite gains checks for three gaps left by the verify of #502: both bridge files present (only the one at the new path counts), the sentences that list the signals read clause by clause (open changes listed again in Chinese are caught, the remark that they do not count is not), and the heading of Step 7. The detection block is unchanged. The change idd-525-conversation-context-not-a-signal modifies the requirement of spectra-bridge-detection and adds one.
…ersation rule in idd-comment (#525) Round 1 of the verify found that the check for "does this sentence list open changes as a signal" and the spec described two different rules: the spec said clauses end at a semicolon and that a remark says they "do not count", the function cut only at a semicolon followed by a space and did not know that wording; an unrelated remark after a comma hid a listing; Chinese wordings were only caught when the English word change followed. The spec now gives the rule in four steps and says that wordings outside it are not recognised. Its Example table has 29 rows, and the suite reads the rows from the spec and runs the rule on each, so the table and the checks cannot differ. idd-comment did not say what the rule file says. Step 0.7 now has a line under its block (conversation context is not a signal; pass --resume-spectra from a spectra-discuss session), and the rule that a spectra context must not be ignored silently refers to the result of Step 0.7 and says it is not inferred from the conversation. The detection block is unchanged. The check for the rule's note looks only below the table, the table check also matches the Chinese term, and the Step 7 check matches the words "only when".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #525
Summary
#502 的 verify 留下的三個小項，都在 spectra bridge 的偵測（
/idd-comment判斷這次呼叫是不是從 spectra-discuss 的討論中途進來的）。plugins/issue-driven-dev/rules/spectra-bridge.md：偵測表拿掉「Conversation context」那一列。idd-comment只讀三個訊號，那一列寫的是不存在的訊號。表的下方加一行：從 spectra-discuss 中途呼叫要帶--resume-spectra。維護者決定不補自動的路。行數不變。plugins/issue-driven-dev/skills/idd-comment/SKILL.md：Step 0.7 區塊下方加一行同樣的說明；鐵律「Spectra context 不可靜默忽略」改成以 Step 0.7 的判定為準，不從對話推斷。偵測的區塊沒有改。spectra-bridge-detection：既有的 requirement 補上「兩個 bridge 檔同時存在時只讀新路徑的」「Step 7 只在 bridge 啟動時執行」，並把「說明文字有沒有把開著的 change 列成訊號」的判斷規則寫成四個步驟；新增一條「對話脈絡不是訊號」。兩個 change 都已封存。scripts/tests/spectra-bridge-detect/test.sh：22 個檢查變成 70 個。判斷規則的 29 個例句直接從規格的表讀。[Unreleased]的條目，版號沒有動。這個 PR 沒有自動合併。 verify 跑了兩輪：第 1 輪（報告）有三個 MEDIUM，修正輪處理了；第 2 輪（報告）還有一個 MEDIUM 與三個 LOW。那個 MEDIUM 是判斷規則的一個漏洞：一句話把那個訊號列回去、後面不加標點接一句講別件事的「不算」，會被判成沒有列入。它只影響三句說明文字的檢查，不影響偵測本身。無人值守的 run 最多兩輪，所以停在這裡，等維護者決定照現在的樣子合併，還是再修一輪。
Verification
Verify gate: not_clean (see the latest verify report on issue #525). /idd-all will not merge this PR; a person decides.
Checklist
Related
#524
🤖 Generated by /idd-all. Do NOT add a GitHub close trailer (Closes/Fixes/Resolves) — IDD discipline requires /idd-close (run by /idd-all's close stage, or by hand) to enforce the checklist gate + closing summary.