Repository navigation
fix: give the edit-run suite a time limit of its own (#508) - #520
Merged
kiki830621 merged 2 commits intoNov 12, 2026
Merged
Conversation
The suite uses about 65 s of CPU, so its wall time grows with the load of the machine; at a load of 50 it reached the 180 s default of run-all-tests.sh and was cut off with no failing check. It now has a timeout file of 1800 s. run-all-tests-self checks that the file is there, holds one number of at least 900, and is applied by the runner.
…he suite itself (#508) Verify round 1: the stand-in suite in run-all-tests-self was named edit-run, so the nested runner emptied the real suite log; 1800 s was longer than the 20-minute CI job limit, so a hung run on CI would cancel the job with no summary. The checks now live in edit-run/test.sh with a stand-in name no real suite has, the limit is 480 s (checked to stay between 360 and 600), and run-all-tests-self is back to what it was.
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #508
Summary
edit-run在機器忙的時候會超過 runner 預設的 180 秒被砍掉，整套測試回報 1 個 suite 失敗，但沒有任何檢查真的失敗。plugins/issue-driven-dev/scripts/tests/edit-run/timeout：這個 suite 自己的時限，480 秒。runner 本來就會讀這個檔。edit-run/test.sh開頭加六個檢查：檔案存在、只有一個數字、介於 360 與 600 之間、假 suite 不與真的 suite 同名、runner 會套用它。run-all-tests.sh只改檔頭的註解；CHANGELOG 加[Unreleased]的條目。no behaviour change（只改測試與測試設定）。verify 跑了兩輪。第 2 輪沒有 MEDIUM 以上的項目；六列 LOW 與 INFO 沒有在這條 branch 上處理，記在 #519。
Verification
Verify gate clean — see the verify report on issue #508. /idd-all merges this PR next if CI and the close-stage guardrails pass.
Checklist
Related
#518（runner 用固定檔名寫紀錄）、#519（verify 第 2 輪的 LOW 與 INFO）
🤖 Generated by /idd-all. Do NOT add a GitHub close trailer (Closes/Fixes/Resolves) — IDD discipline requires /idd-close (run by /idd-all's close stage, or by hand) to enforce the checklist gate + closing summary.