Repository navigation
[enhancement] spec-on-every-issue: round-8 in-scope MEDIUM/LOW left after #480 (Aborted row wording, idd-plan lookup check, approved plan list, chain task text) (#499) - #507
Merged
kiki830621 merged 5 commits intoNov 11, 2026
Conversation
…block, approved plan list, Step 2 text (#499) Four in-scope findings of verify round 8 on issue 480, each with a check that failed before the change: - idd-plan's Aborted row no longer says that idd-implement stops on a plan line left at `proposed` whatever the open changes; the contract's two "only after approval" sentences name the run they hold for. - idd-plan looks up the issue's open change with a fixed bash block (`→ idd-plan change lookup: …`), run by spec-wrapper-contract and compared line for line with the lookup of the contract's step 3. - idd-implement Step 2 leaves a plan headed `## Implementation Plan (Plan tier)` unedited and posts the tasks of the change as a separate `## Spec tasks (change <name>)` comment; a plan it posted itself keeps one `**Spec plan**:` line. - idd-plan no longer says in two places that idd-implement skips its Step 2; the check that compared a string the file no longer held now fails on any line that says a Step 2 is skipped. Spectra change idd-499-round-8-in-scope (open in this commit, archived in the next) modifies the requirement "Spec changes go through Spectra behind IDD wrappers" of capability spec-on-every-issue. Refs #499
Applies the change's delta to openspec/specs/spec-on-every-issue/spec.md and moves the change to the archive. Refs #499
…ents only (#499) Round 1 of the verify of this issue listed five in-scope findings. Change idd-499-fix1 records the two that change behaviour. - The lookup block of idd-plan checks NUMBER before it looks anything up: unset, empty, starting with 0 or not a decimal number prints a stop line and runs no list command. The three lookup lines stay identical to those of the contract step 3, whose own copy still has no such check. - idd-implement Step 2 and the contract say which comments count when the heading of the newest plan decides where the tasks go: those posted by accounts with write access, the selection that spec-change.py plan makes. - Three checks of spec-wrapper-contract were too loose. Each is now run against a sentence it has to catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #499
Summary
#480 第 8 輪 verify 留下的四項，加上這張 verify 第 1 輪列出的五項：
idd-plan的 Aborted 列改成兩句：有開著的 change 時照契約第 3 步停下；沒有時那一行不擋任何 run。規格與契約的「核准之後才 propose」限縮到經idd-plan的 run。idd-plan找開著的 change 改成固定的 bash 區塊，由spec-wrapper-contract抽出執行，並與契約第 3 步的查詢逐行比對。issue 號沒設、以 0 開頭或不是數字時印stop:，不查清單。idd-implementStep 2 不再改寫核准過的 Implementation Plan；change 的 tasks 另貼一則## Spec tasks留言。選留言時只算有寫入權的帳號貼的。idd-plan兩處「跳過 Step 2」改成與 Step 6 一致。idd-499-round-8-in-scope與idd-499-fix1修改，兩者都已封存。版號沒有動，CHANGELOG 加的是[Unreleased]條目。Verification
Verify gate: not_clean (see the latest verify report on issue #499). /idd-all will not merge this PR; a person decides.
第 2 輪判定 PASS、0 blocking，但還有 6 項要在這張處理的問題沒有修（3 項 MEDIUM、3 項 LOW），都是檢查寫得不夠嚴，或說明說得比檢查寬；沒有執行上的缺陷。細節在 第 2 輪的報告。
Checklist
Related
#500（範圍外的 10 項）、#496（契約第 3 步的查詢）、#502（途中遇到、與這張無關的缺陷）
🤖 Generated by /idd-all. Do NOT add a GitHub close trailer (Closes/Fixes/Resolves) — IDD discipline requires /idd-close (run by /idd-all's close stage, or by hand) to enforce the checklist gate + closing summary.