Skip to content

docs: say that a local variable keeps its object reachable until the method returns - #93

Merged
Project516 merged 1 commit into
nextfrom
p516/known-gaps
Nov 17, 2026
Merged

Project516 merged 1 commit into
nextfrom
p516/known-gaps

Conversation

@Project516

@Project516 Project516 commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

What this changes

docs/support.md now says that a local variable keeps its object reachable until its method returns or the slot is overwritten. HotSpot's compiled code can drop the object after the variable's last use, so on java-web such an object is cleared or finalized later. This is why java/lang/ref/ReachabilityFenceTest.java fails. The other gaps that keep OpenJDK tests failing are already in the same file: file mappings larger than native memory, TCP urgent data, and a class loader with a finalize() on a reference cycle.

Tests

Docs only.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0cd62692-0ba0-4a4e-8de3-7c0230be10b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@project516-review-bot project516-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates docs/support.md to document that java-web keeps objects reachable via local variables until the method returns or the variable is overwritten, unlike HotSpot which can drop them after last use. This explains a known test failure in ReachabilityFenceTest.


review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve

@Project516
Project516 merged commit 9277011 into next Nov 17, 2026
5 checks passed
@Project516
Project516 deleted the p516/known-gaps branch November 17, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant