Repository navigation
Add accessible names to CPU masks and log viewer - #99
PrimeBuild-pc merged 2 commits into
Conversation
PrimeBuild-pc
left a comment
There was a problem hiding this comment.
Thanks a lot for this, Libi, and welcome to ThreadPilot! 🎉 This is a really solid first contribution. I pulled it locally and checked it:
- Every interactive control in
MasksView.xamlandLogViewerView.xamlis covered, and the diff only touches the two views and the locale files (no logic changes). - All 16 new keys are present in all 7 locale files, with no duplicates and no typos. Every key referenced from XAML is defined.
- Your translations (it/de/es/fr/ru/zh) read naturally, so nothing to fix there. Thank you for not leaving English placeholders.
dotnet build -c Releasepasses with 0 errors, and all 939 existing tests pass.- The names are clear for a screen reader ("Filter by log level", "Start date for log entries", and so on).
There is just one small thing to change before I merge, in Views/MasksView.xaml, on the per-CPU checkbox in the CPU grid:
AutomationProperties.Name="{Binding Content.Text, RelativeSource={RelativeSource Self}}">This binding resolves to an empty string. I checked it with a small test harness: TextBlock.Text stays empty when the text is built from <Run> elements, as it is here. The explicit name is therefore a no-op, and the name a screen reader announces comes from the checkbox content ("CPU 0", "CPU 1", and so on), so the accessibility result is already correct today. It would just be misleading to the next person reading the file.
Could you remove that one line (leave the <CheckBox.Content> as it is)? Nothing else needs to change. Once that's pushed and CI is green, I'll merge it.
Great work, and thanks again for picking this up!
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for the detailed review! I've removed the ineffective AutomationProperties.Name binding from the per-CPU CheckBox, leaving the CheckBox.Content unchanged. The correction has been committed and pushed to the existing PR. I'll wait for the CI checks to finish. Thanks again! |
PrimeBuild-pc
left a comment
There was a problem hiding this comment.
Perfect, thank you Libi, that's exactly the fix. Build, tests and CI are all green, so I'm merging now. Congrats on your first ThreadPilot contribution, and thanks for the great work on the translations too! 🙌
Summary
Validation
git diff --checkpassed.Microsoft.WindowsDesktop.App 8.0.0.Closes #98