Repository navigation
fix: recover saved-rule monitoring after sleep (v1.7.9) - #96
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Renew WMI subscriptions and rescan running processes after resume, unlock, stopped subscriptions or prolonged event silence. Keep WMI retries independent of fallback polling and serialize recovery with Start/Stop. Subscribe before the initial snapshot to cover processes started during watcher setup. Route app startup through the manual enable path and prepare v1.7.9 metadata.
Reset per-process duplicate suppression before the shared startup and recovery snapshot evaluation so a short sleep cannot suppress rule reapplication.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #95. Keep the issue open until the reporter confirms recovery after sleep.
Sleep could leave WMI subscriptions silent while monitoring still reported active. Previously only active fallback polling retried WMI; there was no resume subscription, silence watchdog or rescan on WMI recovery. The startup snapshot also preceded watcher creation, leaving a gap for processes launched between those operations. Executable-path retries and early diagnostic initialization from the existing branch are included.
Automatic and manual startup already shared
StartAsync()and its initial rule evaluation. App startup now uses the exact manual enable entry point too. The report alone cannot establish why restarting the app was ineffective on the affected machine: a new app process cannot repair Windows WMI provider readiness, and a one-time scan can still encounter temporarily unavailable paths. The patch covers those failure modes without claiming to have reproduced the reporter's full Windows sleep sequence.Evidence
Merge Danger
Door: two-way
Blast Radius: monitoring
Changes are scoped to saved-rule process discovery/recovery and release metadata. Recovery respects monitoring and fallback settings, serializes with Start/Stop, resets rule cooldowns for a fresh startup/recovery scan, and records diagnostics.