Repository navigation
Document QA by Community labels and Committer validation - #321
Merged
Merged
Conversation
nicosomb
approved these changes
Nov 6, 2026
SharakPL
approved these changes
Nov 6, 2026
Progi1984
reviewed
Nov 8, 2026
|
|
||
| QA verification can also be performed by community members. In that case, the <label type="needs">Waiting for QA by Community</label> label is used to request it, and the <label type="check">QA ✔️ by Community</label> label is applied once the verification is done. | ||
|
|
||
| A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the QA team (or by a Committer) before it can be merged. |
Member
There was a problem hiding this comment.
Suggested change
| A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the QA team (or by a Committer) before it can be merged. | |
| A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or by a Committer) before it can be merged. |
| Some other PRs may require QA by a developer, for example if the PR is very technical and does not change the behavior of the software. In that case, you can add `Waiting for QA` and `Waiting for dev` label. This should be discussed with QA functional team. | ||
|
|
||
| If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge. | ||
| QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer). |
Member
There was a problem hiding this comment.
Suggested change
| QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer). | |
| QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or a Committer). |
| If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge. | ||
| QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer). | ||
|
|
||
| If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge. |
Member
There was a problem hiding this comment.
Suggested change
| If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge. | |
| If the PR behavior is confirmed by [QA Team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or a committer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge. |
|
|
||
| Some Pull Requests however cannot be tested by QA team, the Developers team might validate them. | ||
|
|
||
| Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the QA team (or by a Committer). |
Member
There was a problem hiding this comment.
Suggested change
| Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the QA team (or by a Committer). | |
| Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or by a Committer). |
kpodemski
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for QA by CommunityandQA ✔️ by Communitylabels recently introduced on PrestaShop repositories, and clarifies the rule that aQA ✔️ by Communityvalidation is equivalent toQA ✔️only when it was performed by a Committer; otherwise the Pull Request still needs to be verified by the QA team (or a Committer) before being merged.Changes in the Maintainers Guide:
- Reviewing and approving Pull Requests: new "QA verification by the community" subsection, new row in the Labeling reference table, and update of the section explaining when to add QA labels.
- Summary of how GitHub Issues and Pull Requests are processed: "Testing the Pull Request" and "Merging the Pull Request" now mention community QA and the Committer rule.
Both pages link to the Committers list in People and roles. Related contributor-facing update in DevDocs: PrestaShop/docs#2180