Skip to content

Document QA by Community labels and Committer validation - #321

Merged
kpodemski merged 1 commit into
PrestaShop:masterfrom
cnavarro-prestashop:qa-by-community
Nov 10, 2026
Merged

kpodemski merged 1 commit into
PrestaShop:masterfrom
cnavarro-prestashop:qa-by-community

Conversation

@cnavarro-prestashop

Copy link
Copy Markdown
Questions Answers
Description Documents the Waiting for QA by Community and QA ✔️ by Community labels recently introduced on PrestaShop repositories, and clarifies the rule that a QA ✔️ by Community validation is equivalent to QA ✔️ only when it was performed by a Committer; otherwise the Pull Request still needs to be verified by the QA team (or a Committer) before being merged.

Changes in the Maintainers Guide:
- Reviewing and approving Pull Requests: new "QA verification by the community" subsection, new row in the Labeling reference table, and update of the section explaining when to add QA labels.
- Summary of how GitHub Issues and Pull Requests are processed: "Testing the Pull Request" and "Merging the Pull Request" now mention community QA and the Committer rule.

Both pages link to the Committers list in People and roles. Related contributor-facing update in DevDocs: PrestaShop/docs#2180
Fixed ticket N/A


QA verification can also be performed by community members. In that case, the <label type="needs">Waiting for QA by Community</label> label is used to request it, and the <label type="check">QA ✔️ by Community</label> label is applied once the verification is done.

A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the QA team (or by a Committer) before it can be merged.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the QA team (or by a Committer) before it can be merged.
A <label type="check">QA ✔️ by Community</label> label is considered **equivalent to a <label type="check">QA ✔️</label> label** only if the verification was performed by a [Committer][committers]. Otherwise, it is informative only: the Pull Request still needs to be verified by the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or by a Committer) before it can be merged.

Some other PRs may require QA by a developer, for example if the PR is very technical and does not change the behavior of the software. In that case, you can add `Waiting for QA` and `Waiting for dev` label. This should be discussed with QA functional team.

If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge.
QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer).
QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or a Committer).

If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge.
QA verification can also be requested from the community with the `Waiting for QA by Community` label. Once the verification is done, the `QA ✔️ by Community` label is applied. This label is equivalent to `QA ✔️` only if the verification was performed by a [Committer][committers]; otherwise the PR still needs a validation from the QA team (or a Committer).

If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the PR behavior is confirmed by QA Team (or a developer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge.
If the PR behavior is confirmed by [QA Team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or a committer, for the "Waiting for dev PRs, or a Committer, for the "QA ✔️ by Community" PRs), the PR can be merged. See above section `Merging Pull Requests` for the different actions needed following the merge.


Some Pull Requests however cannot be tested by QA team, the Developers team might validate them.

Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the QA team (or by a Committer).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the QA team (or by a Committer).
Pull Requests can also be tested by the community: the "Waiting for QA by Community" label is used to request it, and the "QA ✔️ by Community" label is applied once the test is done. This label is equivalent to "QA approved" only if the test was performed by a [Committer][committers]. Otherwise, the Pull Request must still be validated by the [QA team](https://www.prestashop-project.org/project-organization/people-and-roles/#quality-council) (or by a Committer).

@kpodemski
kpodemski merged commit eb96f2e into PrestaShop:master Nov 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants