Skip to content

Add integer validators - #1728

Open
Naramsim wants to merge 4 commits into
masterfrom
validators-int
Open

Naramsim wants to merge 4 commits into
masterfrom
validators-int

Conversation

@Naramsim

@Naramsim Naramsim commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Change description

by Adding validators we have two benefits:

  1. stricter data contributions checks. If a not valid value is added in the CSV files, the build fails.
  2. validators ranges are expressed in the openapi schema and can be viewed in the new docs
  3. small footprint gain while building the DB

AI coding assistance disclosure

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim
Naramsim requested review from FallenDeity and jemarq04 and removed request for FallenDeity and jemarq04 November 17, 2026 08:10
@Naramsim
Naramsim marked this pull request as draft November 17, 2026 08:14
@Naramsim
Naramsim requested a review from jemarq04 November 17, 2026 09:24
@Naramsim
Naramsim marked this pull request as ready for review November 17, 2026 09:24
@Naramsim
Naramsim requested a review from FallenDeity November 17, 2026 09:24

@phalt phalt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wicked, a great guardrail to add :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants