Repository navigation
chore: sync with arpitg1304/forge main - #8
Merged
Merged
Conversation
…-diagnostics Make quality diagnostics inspectable and add video integrity checks
README - Replace the ASCII banner with three animated concept SVGs (hub, quality timeline, data engine) in docs/assets/readme/ - Correct the formats table: LeRobot v2 is read-only - Add a Known limitations section and refresh the roadmap Fixes - filter: --min-quality rejects episodes whose score is None - lerobot-v3 writer: keep fractional FPS (29.97, 12.5); ints stay ints - lerobot-v3 reader: an explicit codebase_version < 3 is never v3, even when meta/tasks.jsonl exists (v2.1 datasets) - lerobot-v2 reader: warn when a frame is missing or undecodable instead of silently returning a black frame; raise when PyAV is missing - quality: recommend `--exclude-flags gripper_chatter`, which exists - __version__ matches pyproject (0.2.0) Docs - docs/cli.md: web viewer is the default, downloads use the HF cache, --sample/--quick take the first N episodes - forge/io/README.md: --export instead of the nonexistent --report Tests: tests/test_gap_fixes.py adds regression tests for the fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ap-fixes README refresh with concept visuals + quick data-quality fixes
- Drop ACTION_TOKENIZER_PLAN.md (implemented in forge/tokenize/) and the stale v0.1 ROADMAP.md (README roadmap replaces it; removed from sdist) - Drop setup.py (build backend is hatchling) and requirements*.txt (unused by Makefile/CI; dependencies live in pyproject.toml) - Drop examples/test_config.yaml (generated leftover) - Ignore the local .archive/ folder and FORGE_GAPS.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noah-wardlow
marked this pull request as ready for review
November 19, 2026 20:50
Author
|
[written by AI] PickNikRobotics/moveit_pro#24673 pins MoveIt Pro to this PR's head, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Syncs our fork with
arpitg1304/forgemain, so the QUAILs team can use our fork without losing upstream's quality, video, and viewer work. We were 5 commits behind (arpitg1304#42, arpitg1304#43, and a cleanup commit) and 4 ahead (#6, #7).Merge with a merge commit, not squash or rebase. That keeps the upstream commits in our history, so the next sync starts from here instead of re-conflicting.
What we gain
q-v2-proprio, with localized events: held commands, pauses, reversals, and opt-in position-tracking stalls.forge quality --visualize, a rewritten web viewer, and a CPU video benchmark.qualityjob on Python 3.10–3.12.Changes for existing forge users
Read these before upgrading. None of them affects MoveIt Pro (see below).
ValueErrorinstead of returning the last good frame or a black frame.video_min_sharpnessmeans the minimum sampled sharpness, and scorer versions changed. Saved quality filters may need recalibrating.setup.py,requirements*.txt,ROADMAP.md,ACTION_TOKENIZER_PLAN.md, andexamples/test_config.yamlare deleted. Dependencies live only inpyproject.toml.Conflicts and the one fix on top
CHANGELOG.mdandforge/formats/lerobot_v3/reader.pyconflicted textually. Both resolutions keep both sides.Episode.cameraslisted only MP4 cameras. Video quality analysis now builds its per-camera checks from that list, so image-mode datasets (feat(lerobot_v3): add image-mode output to the v3 writer #6) would get no video checks. The reader now declares image-mode cameras withstorage="image".test_image_mode_frames_survive_round_tripcovers it, and it fails without the fix.MoveIt Pro impact
Nothing changes for MoveIt Pro users. MoveIt Pro's Trainer pins this fork at
8e6a978and uses only the MCAP reader and the LeRobot v3 writer (forge_mcap_to_lerobot.py). Upstream does not touch the MCAP reader. The only writer change is the fractional-FPS one, and the Trainer passes integer FPS, soinfo.jsonis unchanged. The pin does not move until a MoveIt Pro PR bumps it.Verified on a MoveIt Pro Runtime at
PickNikRobotics/moveit_pro@b8550e15b1runningvla_sim, with this branch installed:moveit_studio_rest_apipass with this branch and with8e6a978.stats.json, and MP4.info.jsonkeepsfps: 10and the feat(mcap,lerobot_v3): carry JointState joint names into info.json #7 joint names. Both datasets play back in the Desktop App.Tests
tests/test_mcap_*.pyand the newqualityjob's file list): 304 passed, 4 skipped.mainwithout this merge.ruff checkon the files this PR resolves or edits is clean.