Skip to content

chore: sync with arpitg1304/forge main - #8

Merged
noah-wardlow merged 6 commits into
mainfrom
sync/upstream-2026-11
Nov 19, 2026
Merged

noah-wardlow merged 6 commits into
mainfrom
sync/upstream-2026-11

Conversation

@noah-wardlow

@noah-wardlow noah-wardlow commented Nov 19, 2026 •

Copy link
Copy Markdown

[written by AI]

Syncs our fork with arpitg1304/forge main, so the QUAILs team can use our fork without losing upstream's quality, video, and viewer work. We were 5 commits behind (arpitg1304#42, arpitg1304#43, and a cleanup commit) and 4 ahead (#6, #7).

Merge with a merge commit, not squash or rebase. That keeps the upstream commits in our history, so the next sync starts from here instead of re-conflicting.

What we gain

  • Quality scorer q-v2-proprio, with localized events: held commands, pauses, reversals, and opt-in position-tracking stalls.
  • Video integrity reports with per-camera coverage, decode failures, and frame-drop estimates.
  • forge quality --visualize, a rewritten web viewer, and a CPU video benchmark.
  • LeRobot v3 episodes carry metadata FPS and declared cameras. The writer keeps fractional FPS instead of truncating it to an int.
  • A CI quality job on Python 3.10–3.12.

Changes for existing forge users

Read these before upgrading. None of them affects MoveIt Pro (see below).

  • A missing or undecodable LeRobot v3 video frame now raises ValueError instead of returning the last good frame or a black frame.
  • video_min_sharpness means the minimum sampled sharpness, and scorer versions changed. Saved quality filters may need recalibrating.
  • setup.py, requirements*.txt, ROADMAP.md, ACTION_TOKENIZER_PLAN.md, and examples/test_config.yaml are deleted. Dependencies live only in pyproject.toml.

Conflicts and the one fix on top

  • CHANGELOG.md and forge/formats/lerobot_v3/reader.py conflicted textually. Both resolutions keep both sides.
  • Upstream's new Episode.cameras listed only MP4 cameras. Video quality analysis now builds its per-camera checks from that list, so image-mode datasets (feat(lerobot_v3): add image-mode output to the v3 writer #6) would get no video checks. The reader now declares image-mode cameras with storage="image". test_image_mode_frames_survive_round_trip covers it, and it fails without the fix.

MoveIt Pro impact

Nothing changes for MoveIt Pro users. MoveIt Pro's Trainer pins this fork at 8e6a978 and uses only the MCAP reader and the LeRobot v3 writer (forge_mcap_to_lerobot.py). Upstream does not touch the MCAP reader. The only writer change is the fractional-FPS one, and the Trainer passes integer FPS, so info.json is unchanged. The pin does not move until a MoveIt Pro PR bumps it.

Verified on a MoveIt Pro Runtime at PickNikRobotics/moveit_pro@b8550e15b1 running vla_sim, with this branch installed:

  • All 1317 Trainer tests in moveit_studio_rest_api pass with this branch and with 8e6a978.
  • Two episodes recorded and converted from the Desktop App's Trainer pane, once with each forge commit. The datasets are byte-identical apart from the output name and repo ID: every data parquet, episodes parquet, stats.json, and MP4. info.json keeps fps: 10 and the feat(mcap,lerobot_v3): carry JointState joint names into info.json #7 joint names. Both datasets play back in the Desktop App.

Tests

  • The two CI-gated suites (tests/test_mcap_*.py and the new quality job's file list): 304 passed, 4 skipped.
  • Full suite on Python 3.12: 697 passed. The 2 failures and 10 errors (Zarr v3 and a rosbag fixture) also fail on main without this merge.
  • ruff check on the files this PR resolves or edits is clean.

arpitg1304 and others added 6 commits October 17, 2026 01:44
…-diagnostics

Make quality diagnostics inspectable and add video integrity checks
README
- Replace the ASCII banner with three animated concept SVGs
  (hub, quality timeline, data engine) in docs/assets/readme/
- Correct the formats table: LeRobot v2 is read-only
- Add a Known limitations section and refresh the roadmap

Fixes
- filter: --min-quality rejects episodes whose score is None
- lerobot-v3 writer: keep fractional FPS (29.97, 12.5); ints stay ints
- lerobot-v3 reader: an explicit codebase_version < 3 is never v3,
  even when meta/tasks.jsonl exists (v2.1 datasets)
- lerobot-v2 reader: warn when a frame is missing or undecodable
  instead of silently returning a black frame; raise when PyAV is missing
- quality: recommend `--exclude-flags gripper_chatter`, which exists
- __version__ matches pyproject (0.2.0)

Docs
- docs/cli.md: web viewer is the default, downloads use the HF cache,
  --sample/--quick take the first N episodes
- forge/io/README.md: --export instead of the nonexistent --report

Tests: tests/test_gap_fixes.py adds regression tests for the fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ap-fixes

README refresh with concept visuals + quick data-quality fixes
- Drop ACTION_TOKENIZER_PLAN.md (implemented in forge/tokenize/) and the
  stale v0.1 ROADMAP.md (README roadmap replaces it; removed from sdist)
- Drop setup.py (build backend is hatchling) and requirements*.txt
  (unused by Makefile/CI; dependencies live in pyproject.toml)
- Drop examples/test_config.yaml (generated leftover)
- Ignore the local .archive/ folder and FORGE_GAPS.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge arpitg1304/forge main into PickNikRobotics/forge main, keeping PickNik's image-mode writer (#6) and JointState joint names (#7), and declare image-mode cameras on LeRobot v3 episodes so video quality analysis checks them.
@noah-wardlow
noah-wardlow marked this pull request as ready for review November 19, 2026 20:50
@noah-wardlow
noah-wardlow merged commit 3a9185c into main Nov 19, 2026
6 checks passed
@noah-wardlow

Copy link
Copy Markdown
Author

[written by AI]

PickNikRobotics/moveit_pro#24673 pins MoveIt Pro to this PR's head, f968eaf. Merge this PR with a merge commit so that commit stays on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants