Repository navigation
Rescore all files together: one Percolator model and PSM FDR over the whole study - #181
Open
t0mdavid-m wants to merge 3 commits into
Open
t0mdavid-m wants to merge 3 commits into
t0mdavid-m wants to merge 3 commits into
Conversation
An option on the Rescoring tab runs PercolatorAdapter once over every file's matches, so the PSM q-values and PEPs are computed over the whole study, and writes the result back into one idXML per file (src/common/pooled_fdr.py), so filtering, quantification and the result views are unchanged. Off by default; with one file each file is rescored on its own as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
What it does
Right now Percolator rescores each file on its own. Every file gets its own model, and its own q-values and posterior error probabilities. A small or sparse file learns from only a few matches, and the same FDR threshold means slightly different things in different files.
This PR adds Rescore all files together on the Rescoring tab, for both label-free and TMT. The option is off by default.
When it is on and two or more files are processed:
-inlist. That gives one model, with q-values and PEPs computed over the whole study.src/common/pooled_fdr.py(pyOpenMS glue, no Streamlit) writes that result back into one idXML per file (percolator_results/<file>_per.idXML). PercolatorAdapter marks each match's file asfile=<i>,…in its spectrum reference. The split groups the matches by that index, restores the original spectrum reference, and gives each file the protein run of its own search result, plus the annotations Percolator added. FDR filtering, quantification and the result views therefore read the same per-file files as before.percolator_all_files/all_files_per.idXML, separate from the per-file results, so QC and overview counts don't count a match twice.With the option off, or with only one file, nothing changes. Each file is rescored on its own, and a file Percolator cannot learn from is left out while the others go on.
Screenshots
Rescoring tab, light and dark. The red box only appears because this container has no TOPP tools installed.
Tests
tests/test_pooled_fdr.pybuilds idXML files with pyOpenMS shaped like PercolatorAdapter's multi-input output, then checks the split:index=fallback goes back to an empty reference;tests/test_percolator_left_out.pygains two tests:execution()makes a single PercolatorAdapter call with all three inputs, and IDFilter gets one result per file;test_gui.py tests/): 1351 passed. Pylint (errors only) is clean.Generated by Claude Code