Repository navigation
Conversation
maximthomas
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReplicationDomainTest.publishAndReceivechecks the replication server generation IDs 500 ms after resetting the replication log. The reset and the resulting topology messages are asynchronous, andcheckGenerationID()accepts-1, so the check can still see-1even though the reset to2is in progress.Change
Wait up to 30 seconds for both expected replication servers to appear in the directory server's topology with generation ID
2, and for both replication servers to hold2themselves. A missing server or a generation ID that never converges still fails the test.Fixes #1305
Validation
ReplicationDomainTest: 40 tests passed on macOS / JDK 21, with no failures or skips.2by 1.5 seconds. The original 500 ms check reproduced the reported failure; the updated test passed after the reset and topology converged.2. The updated test failed after the bounded wait with the generation ID still at-1.git diff --checkpassed.The diagnostics demonstrate a sufficient timing mechanism, not the exact CI interleaving.