Skip to content

[core] Share path and webhook operation processing in DefaultGenerator - #25696

Open
ChihweiLHBird wants to merge 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:refactor/default-generator-share-operation-processing
Open

ChihweiLHBird wants to merge 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:refactor/default-generator-share-operation-processing

Conversation

@ChihweiLHBird

@ChihweiLHBird ChihweiLHBird commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Refactor only; no generated output changes.

processPaths(Paths) and processWebhooks(Map) in DefaultGenerator were the same loop over the path items and their eight HTTP methods. Both now delegate to a private processPathItems(Map<String, PathItem>). The two public methods keep their signatures.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refactors DefaultGenerator so paths and webhooks share the same operation-processing loop.

processPaths(Paths) and processWebhooks(Map) had identical logic over path items and their eight HTTP methods. Both now delegate to a private processPathItems(Map<String, PathItem>); the public methods keep their signatures. Refactor only, with no changes to generated output.

Written for commit dd15067. Summary will update on new commits.

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

DefaultGenerator handled webhooks with a copy of the code for paths:
processPaths(Paths) and processWebhooks(Map) were the same loop over
the path items and their eight HTTP methods. Both now delegate to a
private processPathItems(Map<String, PathItem>).

The public methods are unchanged.

No generated output changes.
@ChihweiLHBird
ChihweiLHBird force-pushed the refactor/default-generator-share-operation-processing branch from ea663c7 to dd15067 Compare November 16, 2026 04:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant