Repository navigation
[core] Share path and webhook operation processing in DefaultGenerator - #25696
Open
ChihweiLHBird wants to merge 1 commit into
Open
ChihweiLHBird wants to merge 1 commit into
ChihweiLHBird wants to merge 1 commit into
Conversation
DefaultGenerator handled webhooks with a copy of the code for paths: processPaths(Paths) and processWebhooks(Map) were the same loop over the path items and their eight HTTP methods. Both now delegate to a private processPathItems(Map<String, PathItem>). The public methods are unchanged. No generated output changes.
ChihweiLHBird
force-pushed
the
refactor/default-generator-share-operation-processing
branch
from
November 16, 2026 04:50
ea663c7 to
dd15067
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor only; no generated output changes.
processPaths(Paths)andprocessWebhooks(Map)inDefaultGeneratorwere the same loop over the path items and their eight HTTP methods. Both now delegate to a privateprocessPathItems(Map<String, PathItem>). The two public methods keep their signatures.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Refactors
DefaultGeneratorso paths and webhooks share the same operation-processing loop.processPaths(Paths)andprocessWebhooks(Map)had identical logic over path items and their eight HTTP methods. Both now delegate to a privateprocessPathItems(Map<String, PathItem>); the public methods keep their signatures. Refactor only, with no changes to generated output.Written for commit dd15067. Summary will update on new commits.