Repository navigation
[python] drop typing-extensions - #25678
Open
timonrieger wants to merge 2 commits into
Open
timonrieger wants to merge 2 commits into
timonrieger wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 997 files
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotated,Literal,NotRequiredandSelfare all built intotypingsince Python 3.11, the generator's minimum.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@cbornet @tomplus @krjakbrjak @fa0311 @AndreyVMarkelov
🤖 Generated with Claude Code
https://claude.ai/code/session_01XR83Jm91yXcaupiSTHCXnZ
Summary by cubic
Drops the
typing-extensionsdependency from generated Python clients by migrating imports ofAnnotated,Literal,NotRequired, andSelfto the standardtypingmodule, which has included them since Python 3.11 (the generator's minimum supported version). Also removestyping-extensionsfromrequirements.txt,setup.py,pyproject.toml, and the README dependency list, and updates stale samples.Written for commit 7d8a864. Summary will update on new commits.