Repository navigation
point splitter - #954
point splitter#954HansVRP wants to merge 12 commits into
Conversation
b52cd8a to
022c383
Compare
|
@VincentVerelst can you take a look? |
|
@soxofaan could you have a look as well (I do still need to fix the unit tests) |
soxofaan
left a comment
There was a problem hiding this comment.
can't go deep here, just some quick observations
There was a problem hiding this comment.
🟡 Changes recommended
Input features can be duplicated or lost, and custom tile grids do not satisfy the advertised interface contract.
3 open issues
What changed in this PR
Adds point-based job splitting to the existing job-management utilities, supporting sample extraction workflows alongside area-based splitting.
Changes:
- Introduces
split_pointswith optional feature limits, spatial subdivision, and tile-grid grouping. - Exports the helper publicly and documents its usage.
- Adds tests for supported inputs, grouping, reprojection, and validation.
| File | Description |
|---|---|
| tests/extra/job_management/test_job_splitting.py | Tests point splitting and tile-grid behavior. |
| openeo/extra/job_management/_job_splitting.py | Implements point grouping and recursive subdivision. |
| openeo/extra/job_management/__init__.py | Exports split_points publicly. |
| docs/cookbook/job_manager.rst | Adds point-extraction batching examples. |
| CHANGELOG.md | Announces the new helper. |
Review effort: Balanced
|
FYI: any unit test failures you see about jsonschema are fixed with #960, so make sure to merge master to get rid of that problem |
a1ac215 to
30f9394
Compare
Co-authored-by: HansVRP <57984106+HansVRP@users.noreply.github.com>
Co-authored-by: HansVRP <57984106+HansVRP@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The change breaks existing split_area(aoi=...) keyword calls and uses a Shapely 2-only API that causes predefined-grid grouping to fail on supported Shapely 1.8 installations.
2 open issues
3 resolved since last review
Review effort: Balanced
Co-authored-by: HansVRP <57984106+HansVRP@users.noreply.github.com>
Co-authored-by: HansVRP <57984106+HansVRP@users.noreply.github.com>
|
@VincentVerelst @soxofaan ready for another look; I added a comment above with the caveats I know of. |
soxofaan
left a comment
There was a problem hiding this comment.
short on time here, so only this small note
|
|
||
|
|
||
| ## [0.54.0] - 2026-10-28 | ||
| - Add public `group_geometries` helper in `openeo.extra.job_management` for geometry-grouping based job splitting, including optional tile-grid co-grouping. |
There was a problem hiding this comment.
wrong place to put this changelog entry







While working on the ML blueprint I figured it should not be hard to extend the spitting function towards point geometries as well.
@VincentVerelst you are quite familiar with this; can you please chekc and validate as well?
For me the results look good and respect tilegrids as well: