[edusperoni]

Moves the TestRunner suite from a vendored Jasmine 2.0.1 (2014) to jasmine-core 7.0.2, installed from npm instead of committed.

jasmine-core comes from npm

• jasmine-core is a pinned root devDependency (7.0.2).
• A new Stage Test Runner Dependencies phase on the TestRunner target runs tools/stage-test-runner-deps.mjs before Copy Bundle Resources. It copies the package's single-file build and its license into TestRunner/app/Infrastructure/Jasmine/vendor/ (gitignored), which the app-folder reference then bundles.
• The phase finds node through .xcode.env / .xcode.env.local, like the js2c phase. CI already runs npm install at the repo root (scripts/install-ci-deps.sh), so no workflow changes are needed. Locally, run npm install once (README updated).

Harness

• New Infrastructure/Jasmine/boot.js. It keeps declaration order (random: false; the shared Workers suite carries state between specs), the quarantine specFilter and the suite progress beacon. The async-function and fail() shims are dropped because Jasmine now handles both.
• A custom object formatter works around Jasmine's pretty-printer throwing on null-prototype tagged objects such as module namespaces. toBe() builds its message even when it passes, so expect(ns).toBe(ns) threw value.toString is not a function. This is worth reporting upstream.
• Reporters:
  • excluded and notApplicable specs count as skipped.
  • Suite-level errors (afterAll, errors raised between specs) and run-level errors are written as failing JUnit testcases, so verify-junit-xml fails the build on them.
  • XML escaping no longer double-escapes entities, and a ]]> in a stack no longer breaks the CDATA block.

Spec changes

• Global errors. Jasmine 7 fails the running spec when a global error/unhandledrejection event fires; 2.0.1 never saw those events.

  • 15 specs that raise them on purpose (error events, unhandled rejections, escapeException boundaries, worker error forwarding, event-loop drain) run under raisesGlobalErrors (Infrastructure/Jasmine/globalErrorSpy.js). It wraps jasmine.spyOnGlobalErrorsAsync and doesn't cancel the events, so listeners, preventDefault() and the __onUncaughtError fallback still behave as in production.
  • Two worker specs whose error used to be re-reported on the global scope after they had finished now cancel it on the parent.
  • The malformed-URL HTTP loader spec left import("http://") unhandled, and its rejection landed in a later RemoteModuleSecurity spec. It now waits for the import.

• Duplicate names are now a declaration error.

  • MethodCallsTests: 28 instance/static property pairs shared a name; they now use the file's …_Instance…/…_Static… scheme.
  • MethodCallsTests: a spec that had been pasted into another spec's body is split back out.
  • Timers.js: a copied spec is removed.

• Shared tests. The submodule is bumped to common-runtime-tests-app test/jasmine-7-compat. That branch makes the shared specs version-agnostic:

  • worker errors raised on purpose are cancelled on the parent;
  • the Performance observer spec uses the global error spy when it exists;
  • done(reason) failure branches fail on 2.0.1 too.

  The branch is not on master yet. Merge it there first, then point this submodule at master before merging.

Testing

./run_tests.sh --keep-sim, iPhone 16 Pro / iOS 26.3:

Run	Specs	Failures	Skipped
main (Jasmine 2.0.1, shared a2ccd8c)	1836	0	11
main harness + shared test/jasmine-7-compat (backwards-compat check)	1836	0	11
This branch	1836	0	11
This branch, rebuilt after deleting vendor/ (the phase restages it)	1836	0	11

The reporters were also checked in Node against jasmine-core 7 with a fake suite (failing, xit, filtered, pending, afterAll error, done(reason), async); the XML output parses.

Not covered here: Android still runs Jasmine 2.0.1. Only the backwards-compatible shared changes affect it, and I did not run its suite.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn