Skip to content

feat(transaction-pay-controller): add server gasless feature flag - #11432

Merged
matthewwalsh0 merged 1 commit into
mainfrom
feat/server-gasless-flag
Nov 11, 2026
Merged

matthewwalsh0 merged 1 commit into
mainfrom
feat/server-gasless-flag

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Explanation

The server strategy requests gasless quotes (supportsGasless) whenever the account and source chain support EIP-7702, with no client-side way to turn this off.

This adds a confirmations_pay_extended.payStrategies.server.gaslessEnabled feature flag as a kill switch. It defaults to true, so behaviour is unchanged unless the flag is explicitly set to false. When disabled, server quote requests are sent with supportsGasless: false.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Default-on flag with a narrow quote-request change; disabling gasless only affects users when ops explicitly set the flag to false.

Overview
Adds a remote feature-flag kill switch so operators can turn off gasless server quotes without a client release.

A new isServerGaslessEnabled() helper reads confirmations_pay_extended.payStrategies.server.gaslessEnabled from RemoteFeatureFlagController and defaults to true, so behavior is unchanged until the flag is set to false. getServerQuotes now gates supportsGasless on that check alongside the existing EIP-7702 account/chain and Polymarket/Hypercore exclusions, so disabled environments send supportsGasless: false on quote requests.

Unit tests cover the flag helper and the server-quotes path when gasless is off; the package changelog documents the flag.

Reviewed by Cursor Bugbot for commit 68944ee. Bugbot is set up for automated code reviews on this repo. Configure here.

@matthewwalsh0
matthewwalsh0 marked this pull request as ready for review November 11, 2026 11:52
@matthewwalsh0
matthewwalsh0 requested review from a team as code owners November 11, 2026 11:52
@matthewwalsh0
matthewwalsh0 deployed to default-branch November 11, 2026 11:52 — with GitHub Actions Active
jpuri
jpuri previously approved these changes Nov 11, 2026
@matthewwalsh0
matthewwalsh0 added this pull request to the merge queue Nov 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2026
Add payStrategies.server.gaslessEnabled, enabled by default, so gasless
server quotes can be disabled remotely.
@matthewwalsh0
matthewwalsh0 added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 9c6cd15 Nov 11, 2026
72 checks passed
@matthewwalsh0
matthewwalsh0 deleted the feat/server-gasless-flag branch November 11, 2026 15:33
@jpuri jpuri mentioned this pull request Nov 12, 2026
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants