Repository navigation
feat(transaction-pay-controller): add server gasless feature flag - #11432
Merged
Merged
Conversation
jpuri
previously approved these changes
Nov 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 11, 2026
Add payStrategies.server.gaslessEnabled, enabled by default, so gasless server quotes can be disabled remotely.
matthewwalsh0
force-pushed
the
feat/server-gasless-flag
branch
from
November 11, 2026 14:33
dda17f2 to
68944ee
Compare
matthewwalsh0
enabled auto-merge
November 11, 2026 14:44
jpuri
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The server strategy requests gasless quotes (
supportsGasless) whenever the account and source chain support EIP-7702, with no client-side way to turn this off.This adds a
confirmations_pay_extended.payStrategies.server.gaslessEnabledfeature flag as a kill switch. It defaults totrue, so behaviour is unchanged unless the flag is explicitly set tofalse. When disabled, server quote requests are sent withsupportsGasless: false.References
Checklist
Note
Low Risk
Default-on flag with a narrow quote-request change; disabling gasless only affects users when ops explicitly set the flag to false.
Overview
Adds a remote feature-flag kill switch so operators can turn off gasless server quotes without a client release.
A new
isServerGaslessEnabled()helper readsconfirmations_pay_extended.payStrategies.server.gaslessEnabledfromRemoteFeatureFlagControllerand defaults totrue, so behavior is unchanged until the flag is set tofalse.getServerQuotesnow gatessupportsGaslesson that check alongside the existing EIP-7702 account/chain and Polymarket/Hypercore exclusions, so disabled environments sendsupportsGasless: falseon quote requests.Unit tests cover the flag helper and the server-quotes path when gasless is off; the package changelog documents the flag.
Reviewed by Cursor Bugbot for commit 68944ee. Bugbot is set up for automated code reviews on this repo. Configure here.