Repository navigation
CH-302 feat: Add optional async workflow submission timeout - #897
Closed
afonsobspinto wants to merge 2 commits into
Closed
afonsobspinto wants to merge 2 commits into
afonsobspinto wants to merge 2 commits into
Conversation
afonsobspinto
marked this pull request as ready for review
November 9, 2026 19:50
afonsobspinto
marked this pull request as draft
November 11, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CH-302
Problem
AsyncOperation.execute()waits for Argo to acknowledge workflow creation. A stalled Argo response can leave the calling API request waiting indefinitely and keep any database row lock held by the caller. A configurable timeout lets callers limit that wait through the Cloud Harness API.Change
Add an optional
request_timeouttoargo_service.submit_workflow().AsyncOperation.execute()andContainerizedOperation.submit()forward submission options to that service.The Argo SDK accepts a timeout in seconds or a
(connect, read)tuple for the HTTP create request. Cloud Harness closes the HTTP client on success or failure, propagates submission errors, and makes one submission attempt per call. Argo may accept a workflow before the response times out, so callers should check whether it was created before retrying.Validation
Workflowwrapper, one POST per call, and client cleanup.execute()times out after one CREATE attempt and allows the caller to reconcile the outcome.Superseded by #899.