Repository navigation
Conversation
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
…stinct lint_new words, more cases Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
…ver attempted one Review fix: on a partial run, and when mxbuild crashed with no baseline (write kept on purpose), the new closing line told the reader to restore the model, contradicting the text above it. It now says no rollback was attempted. The MXTK-RESULT line is unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane (changes to
skills/,bug-logs/,bin/,project-bin/,project-tests/, pipelines)What changed and why (one paragraph): A program that drives
project-bin/exec.shhad to infer the outcome from exit codes whose meaning differs per script; an outside review of v2026.11.12 reported an orchestrator that read exit 4 ("applied, gate passed, lint only") as a failure. exec.sh now prints one fixed line on every path that reaches a verdict:MXTK-RESULT exec verdict=<applied|applied-lint|applied-unverified|partial|restored|failed|refused> applied=<yes|no|partial|unknown> verified=<yes|no|skipped> lint_new=<N|unknown|blind|skipped|na> exit=<code>. It is built in one function and printed before each path's closing human lines, so it is never the last line. Purely additive: no exit code changes and no existing output line is changed or removed. Paths that never reach a verdict (usage errors, a missing.mpr, an abort underset -e) print no line, and the header says that no line means no verdict, never success. Restore paths that had no closing line of their own get one; it says "rolled back", "NOT rolled back" or "no rollback was attempted" according to what happened. A short pointer is added toskills/harness-architecture.md(on demand).Impact
project-bin/exec.sh(additions only; four existing lines gain a trailing; LINT_NEW=…), a new fixture,skills/harness-architecture.md,CHANGELOG.md. A later PR will rewrite the orchestrator contract section of the same skill on top of this one.Time cost: per exec · 0 s measured on a cloud Linux container · can force rework: n · offset: none neededField evidence — a fictional test app built with the toolkit on 2026-11-12 (Mendix 11.13, mxcli v0.28), real mxbuild gate. Old and new exec.sh on the same script: same exit code, and the output differs by exactly the one added line. Applied:
MXTK-RESULT exec verdict=applied applied=yes verified=yes lint_new=blind exit=0. Refused on purpose (reference to an entity that does not exist):MXTK-RESULT exec verdict=refused applied=no verified=skipped lint_new=na exit=1. Fixtures:test-exec-result-line.sh72 of 72 (stub-based; the line carries no tool output), and the existing exec fixtures unchanged: gate-retry 52, lint-diff 9, lint-autorestore 17, crash-rollback 13, hash-verify 49, gate-kind 32, lock-watch 104, all passing.Independent review: MERGE-AFTER-FIX (verdicts
failedandpartialand the--patchpaths untested; two paths disagreed when a restore itself fails;lint_new=nacovered three different cases), fix round, MERGE-AFTER-FIX again (the new closing line said "restore" on two paths that never attempt one), fixed, then MERGE, no findings at29ca2b78. Not run on macOS or Git Bash.CHANGELOG.mdCHANGELOG.mdline appended in this PR, crediting the sourceGenerated by Claude Code