Repository navigation
Conversation
…matching (#670) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
…m the committed fixture pair Review fix: the line had landed inside the release-cycle paragraph, where cut-release.sh would not find it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane (changes to
skills/,bug-logs/,bin/,project-bin/,project-tests/, pipelines)What changed and why (one paragraph): Refs #670.
project-bin/check-design-reaches-app.shmisread ordinary stylesheets in five ways: a one-line:root{--a:1;--b:2}read as one token with}in its value; a minified built sheet had no root block; class presence was a substring match, so.cardcounted as arrived when only.card-headerexisted; multi-line selector lists and rules inside@mediawere missed;var(--x, fallback)did not count as using--x. All five are fixed by onenormalise_css()step (comments dropped, one selector / declaration /}per line,;insideurl(...)and strings kept) plus a whole-class matcher. Verdict names and exit codes are unchanged. It can turn a project red: a project that passed on the substring reading can now report fewer classes arrived, or0 of N(FAIL). That is the intended correction and the changelog line says so.Impact
project-bin/check-design-reaches-app.sh, its fixture, three captured CSS fixtures,CHANGELOG.md. awk only (checked on mawk; the bracket expressions use\047, which BWK awk accepts; not run on macOS). Temp dir via${TMPDIR:-/tmp}with an EXIT trap.Time cost: per project (run after a design port, not per exec) · +4 s on a cloud Linux container · can force rework: y (a wrongly passing project now fails) · offset: maintainer OKField evidence — a fictional test app built with the toolkit on 2026-11-12 (Mendix 11.13, mxcli v0.28). Old → new on its real design and built sheets: design values seen 7 → 29, theme settings bound 10 → 25 of 46, classes arrived 12 → 8 of 32. Five of the classes the new check calls missing were checked by hand against the built CSS: all five are absent as classes and exist only under other names, so the old "12" was inflated. On the committed capture pair (a second fictional app): tokens arrived 9 of 10 → 32 of 38, knobs bound 10 → 31 of 46. Fixture: 70 passed, 0 failed; the same fixture against the old script fails 15 assertions, all new ones. Both layouts are exercised by the fixture.
Known limits, not fixed here: a class name with an escaped character (
.sm\:hidden) and a class name appearing insideurl(...)can still match falsely (the first predates this PR).Independent review: MERGE-AFTER-FIX twice, both on the changelog line only (first misplaced inside the release-cycle paragraph, then a wrong cause given for the slowdown), fixes pushed, then MERGE, no findings at
9ed2425f. The reviewer fed a hostile stylesheet through the normaliser and found no fault. Not run on macOS or Git Bash.CHANGELOG.mdCHANGELOG.mdline appended in this PR, crediting the sourceGenerated by Claude Code