Skip to content

[test, do not merge] NVHPC OpenMP build experiments for #2117 - #2160

Closed
sbryngelson wants to merge 17 commits into
MFlowCode:masterfrom
sbryngelson:amr-nvtest
Closed

sbryngelson wants to merge 17 commits into
MFlowCode:masterfrom
sbryngelson:amr-nvtest

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

Developed with AI assistance (Claude Code).

Test PR, do not merge or review. A scratch draft for #2117: it runs the GitHub-hosted NVHPC matrix on candidate fixes for an
nvfortran -mp=gpu crash (fort2 SIGSEGV in its store-forwarding pass) in the AMR exchange module, without touching #2117's CI.
It will be closed once a fix is folded into #2117.

…L/HLLC/LF/HLLD, copy primitives only for readers; case-optimized builds compile only the selected Riemann solver
…scalar reductions return their input; fail format on ffmt structure warnings; Cray debug bounds checking; Open MPI oversubscribe; stage-guard lint; validator fixes
…iction/reflux, clustering, nesting, regrid, subcycling, restart)
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Claude Code Review

Head SHA: b4881d2

Files changed:

  • 85 (diff is ~26k lines; only a subset reviewed)
  • .github/scripts/check_caseopt_shared_slugs.py
  • .github/scripts/prebuild-case-optimization.sh
  • .github/scripts/submit-slurm-job.sh
  • .github/workflows/common/build.sh
  • .github/workflows/test.yml
  • CMakeLists.txt
  • cmake/Fypp.cmake
  • cmake/GPU.cmake
  • docs/documentation/amr.md
  • src/simulation/m_amr*.fpp

Findings:
No issues found. Checked in step 4: the CI scripts (check_caseopt_shared_slugs.py, prebuild-case-optimization.sh, common/build.sh, test.yml), CMakeLists.txt, Fypp.cmake and GPU.cmake. The large Fortran AMR sources (src/simulation/m_amr*.fpp and the other src/ files) were NOT reviewed in depth because of the diff size, so this is not a clean bill for them.

…no-MPI scalar reductions return their input; fail format on ffmt structure warnings; Cray debug bounds checking; Open MPI oversubscribe; stage-guard lint; validator fixes
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Lines of Code

File Lines Diff
src/simulation/m_amr_regrid.fpp 917 +917
src/simulation/m_amr_transfer.fpp 827 +827
src/simulation/m_amr_exchange.fpp 749 +749
src/simulation/m_amr_cluster.fpp 585 +585
src/simulation/m_amr_distribution.fpp 552 +552
src/simulation/m_amr_registers.fpp 536 +536
src/simulation/m_amr_store.fpp 475 +475
src/simulation/m_amr_nest.fpp 430 +430
src/simulation/m_amr_state.fpp 403 +403
src/simulation/m_ibm.fpp 2195 +350
src/simulation/m_amr_restart.fpp 303 +303
src/simulation/m_amr_seam.fpp 270 +270
src/simulation/m_amr_frame.fpp 232 +232
src/simulation/m_amr_advance.fpp 227 +227
src/simulation/m_amr_wave.fpp 227 +227
src/post_process/m_data_input.f90 660 +221
src/simulation/m_amr.fpp 210 +210
src/simulation/m_amr_stage.fpp 195 +195
src/simulation/m_amr_ghost.fpp 191 +191
src/post_process/m_data_output.fpp 1412 +155
src/common/m_amr_restart_io.fpp 114 +114
src/simulation/m_phase_timing.fpp 91 +91
src/simulation/m_rhs.fpp 2060 +89
src/simulation/m_global_parameters.fpp 859 +80
src/common/m_box.fpp 39 +39
src/simulation/m_acoustic_src.fpp 551 +35
src/simulation/m_riemann_solver_lf.fpp 553 +32
src/common/m_mpi_common.fpp 1523 +29
src/simulation/m_riemann_solvers.fpp 141 +29
src/simulation/m_start_up.fpp 1300 +29
src/simulation/m_riemann_solver_hllc.fpp 1336 +28
src/simulation/m_igr.fpp 2316 +27
src/simulation/m_weno.fpp 1348 +22
src/common/include/2dHardcodedIC.fpp 453 +21
src/simulation/m_body_forces.fpp 415 +21
src/simulation/m_bubbles_EL.fpp 1656 +17
src/common/include/macros.fpp 141 +13
src/common/include/omp_macros.fpp 391 +11
src/post_process/p_main.fpp 61 +7
src/simulation/m_checker.fpp 76 +7
src/simulation/m_riemann_solver_hlld.fpp 199 +7
src/simulation/m_time_steppers.fpp 903 -7
src/simulation/m_hypoelastic.fpp 640 +6
src/simulation/m_riemann_state.fpp 1182 -6
src/common/m_boundary_common.fpp 453 +5
src/common/m_eos.fpp 520 -5
src/common/m_helper_basic.fpp 123 +5
src/common/m_constants.fpp 93 +4
src/common/m_derived_types.fpp 488 +4
src/common/include/3dHardcodedIC.fpp 250 +3
src/common/m_boundary_io.fpp 319 -3
src/simulation/m_riemann_solver_hll.fpp 624 +3
src/simulation/m_surface_tension.fpp 266 +3
src/common/m_global_parameters_common.fpp 248 -2
src/common/m_variables_conversion.fpp 968 +2
src/post_process/m_start_up.fpp 794 +2
src/simulation/m_cbc.fpp 1112 -2
src/simulation/m_data_output.fpp 1581 +2
src/simulation/m_muscl.fpp 189 +2
src/simulation/m_riemann_solver_hypo_hlld.fpp 785 +2
src/common/include/acc_macros.fpp 283 +1
src/common/include/parallel_macros.fpp 252 +1
src/post_process/m_global_parameters.fpp 400 +1
src/pre_process/m_data_output.fpp 677 +1
src/simulation/m_bubbles_EE.fpp 305 +1
src/simulation/m_thinc.fpp 313 +1
Directory Lines Diff
common 10786 +242
pre_process 5023 +1
simulation 36778 +8198
post_process 3870 +386
total 56457 +8827

@sbryngelson

Copy link
Copy Markdown
Member Author

Folded into #2117; closing the scratch test PR.

@sbryngelson sbryngelson closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant