Repository navigation
fix(linux): map the ABNT2 dedicated slash key - #227
Open
nanaoniiiii wants to merge 1 commit into
Open
nanaoniiiii wants to merge 1 commit into
nanaoniiiii wants to merge 1 commit into
Conversation
|
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Map
VK_ABNT_C1(0xC1), the Brazilian ABNT2 dedicated slash/question-mark key, to LinuxKEY_RO. The uinput backend currently rejects this virtual key as unsupported, so no key event reaches the host layout.The existing keyboard capability setup already enables Linux key codes; the regression now also checks that
KEY_ROis advertised. Add translation and pipe-backed press/release coverage using the production backend and existing test hooks. This changes only the Linux uinput mapping.Screenshot
Issues Fixed or Closed
/ ?key) — key is silently dropped SunshineStream/Sunshine#6051 (host-side dependency fix).Roadmap Issues
Testing
Validated on Linux with GCC 12 and C++23:
tests/unit/test_linux_backend.cppGoogleTest source against the production library, repository-pinned GoogleTest, and existing Linux test hooks. Without the mapping, the translation and new ABNT2 event tests fail; with the mapping, the focused keyboard/capability group passes (8 tests).LinuxBackendTest.*Keyboard*:LinuxBackendTest.FakeUinputConstructionCoversCapabilitiesAndFailureBranches.LIBVIRTUALHID_WARNINGS_AS_ERRORS=OFFbecause the existing XTest-disabledcreate_xtest_mousepath has an unusedoptionsparameter; no build configuration or unrelated source was changed in this PR.brlayout /abnt2model confirms evdevKEY_RO(XKB keycode 97) yields/, and Shift yields?.clang-format --dry-run --Werroron both changed C++ files andgit diff --checkpassed.The selected GoogleTest translation unit was compiled directly. These pipe/fake-syscall tests cover event emission and advertised capabilities in userspace; the XKB check covers software layout translation.
Type of Change
Checklist
AI Usage
See our AI usage policy.