Repository navigation
fix: label discussions with preceding form fields - #1146
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The topic-labeling workflow only inspected the first
h3in a discussion. Themerr, Actions, and Libraries forms put product fields beforeSelect Topic Area, so their discussions silently skipped labeling. In discussion #1145, the selectedFeature Requestwas ignored because the first heading wasSelect Themerr Product.Find the topic heading by its text anywhere in the form, keep the existing supported-topic allowlist, and let unexpected parser errors fail the workflow. Extract the parser into a tested helper and run its regression suite in CI. Add a manual
discussion_numberinput so existing missed discussions can be labeled after merging.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
npm test: all 23 tests passed, covering every supported topic across all current form layouts, HTML entities, whitespace, and missing or invalid fields. The ten Actions/Libraries and Themerr cases failed against the original first-heading lookup and passed with the fix.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/label-templated-discussions.yml .github/workflows/tests.yml: passed.yamllinton both workflows with the repository's applicable line-length and truthy settings: passed.git diff --cached --check: passed.Type of Change
Checklist
AI Usage
See our AI usage policy.