Repository navigation
Conversation
On Wayland, `getActiveWindow()` and `getAllWindows()` queried GNOME Shell through `gdbus` `Eval`. That fails outside GNOME (e.g. KDE) and on GNOME without `unsafe_mode`, and even when it works it only returns windows that have an X Window ID. The compositor manages XWayland windows as an X11 window manager, so EWMH on the X server already lists them and tracks the active one. - Remove `_WgetAllWindows` and unused `LinuxWindow._currSessionType` - Drop `unsafe_mode` instructions from docstrings and README - Add test that finds windows without GNOME Shell running
Collaborator
Author
|
Ruff recently changed its list of rules enabled by default to include a lot more ! I'll update all 4 related projects CI over the weekend. Edit: Ruff on CI wasn't using the lockfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland,
getActiveWindow()andgetAllWindows()queried GNOME Shell throughgdbusEval. That fails outside GNOME (e.g. KDE) and on GNOME withoutunsafe_mode, and even when it works it only returns windows that have an X Window ID. The compositor manages XWayland windows as an X11 window manager, so EWMH on the X server already lists them and tracks the active one._WgetAllWindowsand unusedLinuxWindow._currSessionTypeunsafe_modeinstructions from docstrings and READMETaken from my own patches in AutoSplit for XWayland support: Toufool/AutoSplit@
81ff9bd(#380)I'm still on X11 myself, but between Ubuntu 26.04's GNOME and KDE Plasma 6.8 completely dropping X11 sessions, this is becoming important.