Repository navigation
Swap the positions of Real and AbstractGray in promote_rule - #234
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 3 3
Lines 272 272
=======================================
Hits 263 263
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Real and AbstractGray in the promotion rulesReal and AbstractGray in the promotion rule
Real and AbstractGray in the promotion ruleReal and AbstractGray in promote_rule
kimikage
force-pushed
the
promote_gray_real
branch
from
November 15, 2026 02:13
3981449 to
0ac0f66
Compare
Collaborator
Author
|
https://perf.julialang.org/?tab=bench-ttfx&tt=14&tk=CairoMakie%2FPlot-A-Sine-Wave&pop=ttfx-job-01a1dd66-965a-49ce-9995-e5d883e44a9e Although that specific invalidation has been removed, the overall effect remains the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this isn't a fundamental solution or a silver bullet, experience has shown that it might reduce the risk of invalidation.
In addition, since this package does not specify the actual rules to be followed when no component type is specified, this narrows down the scope to
AbstractGray{T}.The invalidation counts in CairoMakie TTFX Benchmark
https://perf.julialang.org/?tab=bench-ttfx&tt=14&tk=CairoMakie%2FPlot-A-Sine-Wave
Since those invalidations occur in methods whose first argument is a type of
Real, this change should at least resolve them.