Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions email_validator/syntax.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,14 @@ def validate_email_local_part(local: str, allow_smtputf8: bool = True, allow_emp
if valid == "quoted":
local = '"' + re.sub(r'(["\\])', r'\\\1', local) + '"'

# The length limit applies to the local part as it is transmitted
# (RFC 5321 4.5.3.1.1), which for a quoted string includes the
# surrounding quotes and any backslash escapes, so check it again
# now that they have been added back.
if strict and len(local) > LOCAL_PART_MAX_LENGTH:
reason = get_length_reason(local, limit=LOCAL_PART_MAX_LENGTH)
raise EmailSyntaxError(f"The email address is too long before the @-sign {reason}.")

return {
"local_part": local,
"ascii_local_part": local if not requires_smtputf8 else None,
Expand Down
32 changes: 32 additions & 0 deletions tests/test_syntax.py
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,38 @@ def test_email_invalid_syntax_strict(email_input: str, error_msg: str) -> None:
assert str(exc_info.value) == error_msg


@pytest.mark.parametrize(
'email_input,error_msg',
[
# 63 characters plus the two quotes needed because of the space.
('"' + 'a' * 62 + ' "@example.com', 'The email address is too long before the @-sign (1 character too many).'),
# 32 escaped quotes are 64 characters plus the two surrounding quotes.
('"' + '\\"' * 32 + '"@example.com', 'The email address is too long before the @-sign (2 characters too many).'),
# 62 characters, of which one is a backslash that stays escaped, plus the two quotes.
('"' + 'a' * 61 + '\\\\"@example.com', 'The email address is too long before the @-sign (1 character too many).'),
])
def test_email_invalid_syntax_strict_quoted(email_input: str, error_msg: str) -> None:
# The local part length limit applies to the quoted
# local part including its quotes and escapes.
validate_email(email_input, allow_quoted_local=True, check_deliverability=False) # pass without strict
with pytest.raises(EmailSyntaxError) as exc_info:
validate_email(email_input, allow_quoted_local=True, strict=True, check_deliverability=False)
assert str(exc_info.value) == error_msg


@pytest.mark.parametrize(
'email_input,normalized',
[
# 62 characters plus the two quotes is exactly 64.
('"' + 'a' * 61 + ' "@example.com', '"' + 'a' * 61 + ' "@example.com'),
# Unnecessary escapes are removed before the length is checked.
('"' + '\\a' * 64 + '"@example.com', 'a' * 64 + '@example.com'),
])
def test_email_valid_strict_quoted(email_input: str, normalized: str) -> None:
validated = validate_email(email_input, allow_quoted_local=True, strict=True, check_deliverability=False)
assert validated.normalized == normalized


@pytest.mark.parametrize(
'email_input',
[
Expand Down