Repository navigation
Fix task cancellation stopping the worker on macOS - #1173
Open
masakiaota wants to merge 1 commit into
Open
masakiaota wants to merge 1 commit into
masakiaota wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1171
setsid()was inside thecfg(target_os = "linux")block together withprctl, so on macOS the task stayed in the worker's process group. Cancelling a task sentkillpgto the worker too.This calls
setsid()on all Unix targets and keeps onlyprctl(PR_SET_PDEATHSIG)Linux-specific. Nothing changes on Linux.Tested on macOS (arm64) with the reproduction from the issue: the worker stays alive after
hq job cancel 1and job 2 finishes.