Repository navigation
Normalize line endings to LF - #293
Merged
Merged
Conversation
Use the same .gitattributes as dpnp, so that text files are stored with LF, and renormalize the files that were stored with CRLF.
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 22, 2026 13:03
jharlow-intel
approved these changes
Nov 9, 2026
jharlow-intel
left a comment
jharlow-intel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One tracked file was stored with CRLF line endings, while every other file in the repository uses LF:
mkl_umath/_init_helper.pyBecause the repository has no
.gitattributes, git keeps whatever line endings a file was committed with, so the whole file shows as changed when it is edited with a tool that writes LF. This PR adds the.gitattributesthat dpnp uses:It stores all text files with LF and checks them out with LF,
.batfiles included, as in dpnp. The files above are renormalized withgit add --renormalize .. Their contents don't change:git diff --ignore-cr-at-eolshows only.gitattributes. The same change is proposed in IntelPython/mkl_random#203 and IntelPython/dpctl#2396.