Repository navigation
Align conda-forge recipe and workflow with the feedstock - #202
Merged
Merged
Conversation
- Require numpy >=1.26.4 at runtime instead of pin_compatible, as in pyproject.toml and the feedstock - Take mkl from the mkl-devel run_exports - Require meson >=1.8.3, as meson.build does - Move cmake and ninja to build requirements and drop wheel - Drop compiler version pins and use the feedstock's stdlib pins (sysroot 2.17, macOS 11.0) - Note in build scripts why MKLROOT must not be set - Build against the latest numpy 2.x and drop Python 3.10 from the conda-forge workflow matrix
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 22, 2026 12:37
conda build --numpy 2 turns the pin into the version "2.", which libmamba fails to parse. Set numpy: '2' in conda_build_config.yaml, as the feedstock does, and drop numpy from the workflow matrix: the test environments get the newest numpy 2.x without a pin.
Test the built package with the test section of conda-recipe-cf, as the feedstock does: the imports, pip check and pytest. The test jobs stay separate from the build jobs.
jharlow-intel
approved these changes
Nov 9, 2026
jharlow-intel
left a comment
jharlow-intel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good, and running the recipe's own test section means pip check finally runs in CI.
jharlow-intel
added a commit
that referenced
this pull request
Nov 9, 2026
.github/copilot-instructions.md follows the mkl_fft and mkl_umath ones, with #91's rules checked against the meson build. The root AGENTS.md gains #91's two RNG guardrails, so agents that read only AGENTS.md get them too. .github/AGENTS.md says how each conda workflow tests the package since #202. Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns
conda-recipe-cfand the "Conda package using conda-forge" workflow with conda-forge/mkl_random-feedstock, so that upstream CI builds what conda-forge ships.Recipe (
conda-recipe-cf/meta.yaml)numpy >=1.26.4instead ofpin_compatible('numpy', min_pin="x.x", max_pin="x"). With the old pin, a package built against numpy 2.3 requirednumpy >=2.3,<3, which contradictspyproject.toml.numpyis also removed fromignore_run_exports.mklrun requirement. The weak run_export ofmkl-develalready addsmkl >=X.Y,<X+1.meson >=1.8.3to host, asmeson.buildrequires.cmakeandninjato build requirements and dropwheel, which meson-python doesn't use.Build config (
conda-recipe-cf/conda_build_config.yaml)cxx_compiler_version: 14was set on Linux), so the newest conda-forge compilers are used.sysroot 2.17(was 2.28) and macOS deployment target11.0.Build scripts
MKLROOTmust not be set.Workflow (
conda-package-cf.yml)numpy: '2'inconda_build_config.yaml(passing--numpy 2toconda buildfails, because it turns into the unparsable version"2."). Test environments get the newest numpy 2.x without a pin. Before, Python 3.11 to 3.14 built and tested against numpy 2.3, while the feedstock uses 2.4.6 or 2.5.4.conda build --test, which runs the recipe's test section (the imports,pip checkand pytest), as the feedstock does. Before, the test jobs ran only pytest, andpip checkfrom the recipe never ran because the build uses--no-test. The test jobs stay separate from the build jobs.